Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #82457, markdown open, but unfocused source tab #85506

Merged
merged 1 commit into from Nov 25, 2019

Conversation

@hypercubestart
Copy link
Contributor

hypercubestart commented Nov 24, 2019

This PR fixes #82457.

This fix first opens the source tab of the currently focused markdown file using the showSource command. This would make the source tab part of vscode.window.visibleTextEditors, which can be iterated over and the appropriate line to select can be set. This makes sure that if the source tab is already open but unfocused, double clicking on a line in markdown will not create another tab of the markdown source file.

Testing: steps for reproduction provided by @GehDoc in #82457

Current behavior: new tab opened for source markdown file
Expected behavior: unfocused source file tab is focused

@mjbvz mjbvz added this to the November 2019 milestone Nov 25, 2019
@mjbvz mjbvz merged commit 37eeb37 into microsoft:master Nov 25, 2019
5 checks passed
5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20191124.18 succeeded
Details
license/cla All CLA requirements met.
@mjbvz

This comment has been minimized.

Copy link
Contributor

mjbvz commented Nov 25, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.