Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes compressedNavigationController ends with outdated state after startup #86574

Merged
merged 1 commit into from Dec 9, 2019

Conversation

@jeanp413
Copy link
Contributor

jeanp413 commented Dec 9, 2019

This PR fixes #86573

@isidorn isidorn self-assigned this Dec 9, 2019
@isidorn

This comment has been minimized.

Copy link
Contributor

isidorn commented Dec 9, 2019

I have verified this fixes the issue.
Also I think the approach makes sense: whenver we get rendered we shuold re-xtract from the html.
As for the perf implication since we have compressed navigation controllers only for a view port it should not be adding that many listeners at the end of the day.

Thanks a lot for the PR. I will merge it in for our insiders release. And if we decide that the issue should be fixed for stable I will create a new PR which just cherry picks your commit on top of the release branch.

@isidorn isidorn merged commit 1f0c87a into microsoft:master Dec 9, 2019
5 checks passed
5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20191209.5 succeeded
Details
license/cla All CLA requirements met.
Details
@jeanp413 jeanp413 deleted the jeanp413:fix-86573 branch Dec 9, 2019
isidorn added a commit that referenced this pull request Dec 10, 2019
Fixes compressedNavigationController ends with outdated state after startup
chrmarti added a commit that referenced this pull request Dec 10, 2019
Fixes compressedNavigationController ends with outdated state after startup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.