Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mirror cursor selection #86986

Merged
merged 3 commits into from Dec 17, 2019
Merged

Fix mirror cursor selection #86986

merged 3 commits into from Dec 17, 2019

Conversation

mrahhal
Copy link
Contributor

@mrahhal mrahhal commented Dec 14, 2019 •
edited

This PR fixes #86978

Before:

PP2udhl7tV

After:

egeIm9byNZ

@msftclas
Copy link

msftclas commented Dec 14, 2019 •
edited

CLA assistant check
All CLA requirements met.

@octref
Copy link
Contributor

octref commented Dec 17, 2019

Thanks. I added some comment and improved the logic. When it's selection (4 points), we should exit this mode when either both anchors or both actives are located in different locations.

@octref octref added this to the December/January 2020 milestone Dec 17, 2019
@octref octref merged commit ac6f37e into microsoft:master Dec 17, 2019
@mrahhal mrahhal deleted the mirror-cursor-selection-fix branch December 18, 2019 05:09
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@octref octref

Labels
None yet
Projects
None yet
Milestone
January 2020
Development

Successfully merging this pull request may close these issues.

Mirror cursor breaks HTML tags
3 participants
@mrahhal @msftclas @octref