From 819556c104484ee283e717f7f1e810188960b051 Mon Sep 17 00:00:00 2001 From: Alex Ross Date: Tue, 7 Jan 2020 15:13:23 +0100 Subject: [PATCH 1/2] Open external only working for remote extensions --- src/vs/workbench/api/common/extHost.api.impl.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/api/common/extHost.api.impl.ts b/src/vs/workbench/api/common/extHost.api.impl.ts index 87558e6d0eccd..936e2f6fbde39 100644 --- a/src/vs/workbench/api/common/extHost.api.impl.ts +++ b/src/vs/workbench/api/common/extHost.api.impl.ts @@ -245,7 +245,7 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I return extHostTerminalService.getDefaultShell(false, configProvider); }, openExternal(uri: URI) { - return extHostWindow.openUri(uri, { allowTunneling: !!initData.remote.isRemote }); + return extHostWindow.openUri(uri, { allowTunneling: !!initData.remote.authority }); }, asExternalUri(uri: URI) { if (uri.scheme === initData.environment.appUriScheme) { From 633ee66b864299fdad7f4b8bfc6d699e7a96fb1a Mon Sep 17 00:00:00 2001 From: Alex Ross Date: Tue, 7 Jan 2020 15:14:46 +0100 Subject: [PATCH 2/2] Fix asExternalUri too --- src/vs/workbench/api/common/extHost.api.impl.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/api/common/extHost.api.impl.ts b/src/vs/workbench/api/common/extHost.api.impl.ts index 936e2f6fbde39..d38277ed35b55 100644 --- a/src/vs/workbench/api/common/extHost.api.impl.ts +++ b/src/vs/workbench/api/common/extHost.api.impl.ts @@ -252,7 +252,7 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I return extHostUrls.createAppUri(uri); } - return extHostWindow.asExternalUri(uri, { allowTunneling: !!initData.remote.isRemote }); + return extHostWindow.asExternalUri(uri, { allowTunneling: !!initData.remote.authority }); }, get remoteName() { return getRemoteName(initData.remote.authority);