Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
As the results returned by the TypeScript server are limited, we also add a Typescript plugin (typescript-vscode-sh-plugin) to enrich more token classifications that not only consist of Token types but also token modifiers.
Once we have validated out APIs we will talk to the TypeScript team to adopt the changes.
@mjbvz Ok, if I push this to master?
* fix(debug): don't insert task boundaries between events See discussion in microsoft/vscode-js-debug#206. This PR adjusts logic such that we only assert task boundaries around requests and responses, rather than around every single event. I believe this will solve the primary case where misordering can happen, as given in the existing unit test and described more verbosely in the doc comment in this PR. A more conservative approach would be to only omit the boundary between events of the same type. That would be safer, but I browsing through the code I didn't see any cases where it looked like we could get tripped up by bucketing here (e.g. cases where we resolve a deferred promise in an event handler). Seems to fix the performance issue for me. * fixup! add unit tests for ordering
FYI @aeschli I will remove this because VS Code is written to handle this correctly.
i.e. in the core, the document version when the request is made is remembered and then when the result comes in, the result will be "adjusted" with the same adjusting code running when typing.