Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added remembering end key state behaviour #88664

Merged
merged 2 commits into from Feb 4, 2020
Merged

Conversation

@rohanrhu
Copy link
Contributor

rohanrhu commented Jan 15, 2020

Hi, I added end key remembering behaviour that exists in almost all editors. When you go to end of the line with end key, it will stay at end of lines while you move up and down on lines.

@msftclas

This comment has been minimized.

Copy link

msftclas commented Jan 15, 2020

CLA assistant check
All CLA requirements met.

@rohanrhu rohanrhu requested review from alexdima and bpasero Jan 15, 2020
@bpasero bpasero removed their request for review Jan 15, 2020
@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Jan 15, 2020

@rohanrhu what is the additional gulp-bom dependecy supposed to mean?

@rohanrhu

This comment has been minimized.

Copy link
Contributor Author

rohanrhu commented Jan 15, 2020

@rohanrhu what is the additional gulp-bom dependecy supposed to mean?

I installed that because error on building vscode on cmd (OS: Windows 10, Py: Python 3). It was giving error (no gulp-bom package on npm).

@alexdima alexdima merged commit 32606ee into microsoft:master Feb 4, 2020
1 of 5 checks passed
1 of 5 checks passed
linux linux
Details
windows windows
Details
darwin darwin
Details
VS Code #20200115.23 failed
Details
license/cla All CLA requirements met.
Details
@alexdima

This comment has been minimized.

Copy link
Member

alexdima commented Feb 4, 2020

Thank you. I ended up simplifying the change to https://github.com/microsoft/vscode/compare/a2defb0625..718053ccfc

@alexdima alexdima added this to the February 2020 milestone Feb 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.