Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #88294 Add commitData in commit interface #89005

Merged
merged 6 commits into from Feb 18, 2020

Conversation

@zjysdhr
Copy link
Contributor

zjysdhr commented Jan 21, 2020

This PR fixes #88294

@zjysdhr zjysdhr requested a review from joaomoreno Jan 21, 2020
@msftclas

This comment has been minimized.

Copy link

msftclas commented Jan 21, 2020

CLA assistant check
All CLA requirements met.

@zjysdhr zjysdhr force-pushed the zjysdhr:issue/88294 branch from e46c4b3 to 51b8bd5 Jan 29, 2020
@zjysdhr zjysdhr changed the title Fix #88294 Add authorName and commitData in commit interface Fix #88294 Add commitData in commit interface Jan 29, 2020
@zjysdhr

This comment has been minimized.

Copy link
Contributor Author

zjysdhr commented Jan 29, 2020

by #89262, we only need to add commitData.

zjysdhr added 4 commits Jan 30, 2020
@joaomoreno joaomoreno added this to the February 2020 milestone Feb 18, 2020
@joaomoreno joaomoreno merged commit c77f8a8 into microsoft:master Feb 18, 2020
1 of 5 checks passed
1 of 5 checks passed
linux linux
Details
windows windows
Details
darwin darwin
Details
VS Code in progress
Details
license/cla All CLA requirements met.
Details
@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Feb 18, 2020

Thanks! 👍

@zjysdhr zjysdhr deleted the zjysdhr:issue/88294 branch Feb 18, 2020
@alexdima

This comment has been minimized.

Copy link
Member

alexdima commented Feb 18, 2020

@joaomoreno I had to revert this via aa70f38 because it was causing a test to fail, and it appeared to be a real failure, not just a test fluke.

alexdima referenced this pull request Feb 18, 2020
This reverts commit 51b8bd5.
@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Feb 18, 2020

Thanks for the heads up @alexdima

@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Feb 18, 2020

I've fixed it: the tests needed adoption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.