Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style diff editor's scrollable viewport just like any other scrollbar #89660

Merged
merged 3 commits into from Feb 4, 2020

Conversation

@robertrossmann
Copy link
Contributor

robertrossmann commented Jan 29, 2020

This styles the diff editor's scrollbar in the same way as any other scrollbar. As an added bonus, it now inherits the colour from the theme colour. 馃帹

Before

The diff scrollbar on the right is always white and does not blend well with some themes.

diff viewport - white

After

The diff scrollbar on the right inherits the generic scrollbar's colour provided by the current theme. 馃帹

diff viewport - themeable

Implementation notes

At this moment, I simply re-used the theme variables for regular scrollbar sliders as the thingy really looks a lot like a scrollbar slider. However, I am not opposed to the idea of introducing a completely new colour customisation variable for it.

Also note that after second thought I feel I should somehow use registerThemingParticipant() in the git builtin package to get this working, but I'll let you guide me first before I venture forth. 鉂わ笍

My ultimate goal is simply to have that diff overview thingy themeable.

@msftclas

This comment has been minimized.

Copy link

msftclas commented Jan 29, 2020

CLA assistant check
All CLA requirements met.

alexdima added 2 commits Feb 4, 2020
@alexdima alexdima added this to the February 2020 milestone Feb 4, 2020
@alexdima

This comment has been minimized.

Copy link
Member

alexdima commented Feb 4, 2020

Thank you!

@alexdima alexdima merged commit 64b2224 into microsoft:master Feb 4, 2020
4 of 5 checks passed
4 of 5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code in progress
Details
license/cla All CLA requirements met.
Details
@robertrossmann robertrossmann deleted the robertrossmann:feat/diff-viewport-colour branch Feb 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can鈥檛 perform that action at this time.