Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 89899 - improve description of editor.foldingStrategy setting #89925

Merged
merged 1 commit into from Feb 4, 2020

Conversation

@gjsjohnmurray
Copy link
Contributor

gjsjohnmurray commented Feb 3, 2020

This PR fixes #89899

image

image

The term 'strategy' has been retained. For one thing, it would be complicated to migrate to a new setting ID. For another, the term 'strategy' is widely used for similar things elsewhere in the product.

@aeschli aeschli assigned aeschli and unassigned alexdima Feb 3, 2020
@aeschli aeschli self-requested a review Feb 3, 2020
@aeschli aeschli merged commit 6346697 into microsoft:master Feb 4, 2020
5 checks passed
5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20200203.68 succeeded
Details
license/cla All CLA requirements met.
@aeschli

This comment has been minimized.

Copy link
Contributor

aeschli commented Feb 4, 2020

Thanks @gjsjohnmurray !

@aeschli aeschli added this to the February 2020 milestone Feb 4, 2020
@gjsjohnmurray gjsjohnmurray deleted the gjsjohnmurray:fix-89899 branch Feb 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.