Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug where one could open 'peek' inside 'peek' on definition link #90109

Merged
merged 1 commit into from Feb 6, 2020

Conversation

@GustavoASC
Copy link
Contributor

GustavoASC commented Feb 5, 2020

This PR fixes #90107.
When the new setting 'Definition Link Opens in Peek' is checked, a new peek widget will be opened if and only if there is no peek widget open yet (user is not inside a peek context).

Otherwise it performs a normal Go To Definition.

Peek-solved

@GustavoASC GustavoASC requested a review from jrieken Feb 5, 2020
@jrieken
jrieken approved these changes Feb 6, 2020
@jrieken jrieken added this to the February 2020 milestone Feb 6, 2020
@jrieken jrieken merged commit 8a4873d into microsoft:master Feb 6, 2020
5 checks passed
5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20200205.122 succeeded
Details
license/cla All CLA requirements met.
Details
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.