Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify language when creating new git branch #90160

Merged

Conversation

@eyeino
Copy link
Contributor

eyeino commented Feb 6, 2020

When using the git extension, the intent is clear when clicking on "+ Create new branch..." and immediately being prompted "Please provide a branch name". But, when clicking on "+ Create a new branch from..." the intent is ambiguous, since the statement "Please provide a branch name" could refer to the branch from which you wish to base the new branch on or the name of the new branch, the latter being what actually happens.

By specifying "Please provide a new branch name...", the intent is clear: the prompt is asking for the name you wish to call the new branch.

This PR fixes #90158

When using the git extension, the intent is clear when clicking on "+ Create new branch..." and immediately being prompted "Please provide a branch name". But, when clicking on "+ Create a new branch from..." the intent is ambiguous, since the statement "Please provide a branch name" could refer to the branch from which you wish to base the new branch on or the name of the new branch, the latter being what actually happens.

By specifying "Please provide a *new* branch name...", the intent is clear: the prompt is asking for the name you wish to call the new branch.
Copy link
Contributor

gjsjohnmurray left a comment

Maybe make placeholder be "New branch name"

Maybe expand prompt to read "Please provide a name for the new branch"

@joaomoreno joaomoreno merged commit 1302e22 into microsoft:master Feb 7, 2020
4 of 5 checks passed
4 of 5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20200206.75 failed
Details
license/cla All CLA requirements met.
@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Feb 7, 2020

Thanks! 👍

@joaomoreno joaomoreno added this to the February 2020 milestone Feb 7, 2020
@joaomoreno joaomoreno added the git label Feb 7, 2020
@eyeino eyeino deleted the eyeino:eyeino/clarify-new-branch-prompt branch Feb 9, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.