Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a password attribute to input variable of type "promptString". #90482

Merged
merged 2 commits into from Feb 20, 2020

Conversation

@jlittorin
Copy link
Contributor

jlittorin commented Feb 11, 2020

Setting the password attribute to true will cause the UI to not show the type value.

"inputs": [
  {
    "id": "authPassword",
    "type": "promptString",
    "description": "Password for authentication",
    "password": true
  }
]

This PR fixes #90481

…Setting this attribute to true will cause the UI to not show the type value.
@msftclas

This comment has been minimized.

Copy link

msftclas commented Feb 11, 2020

CLA assistant check
All CLA requirements met.

@jlittorin jlittorin requested a review from alexr00 Feb 11, 2020
@jlittorin jlittorin changed the title Added a password attribute to variable input of type "promptString". Added a password attribute to input variable of type "promptString". Feb 11, 2020
@alexr00 alexr00 added this to the February 2020 milestone Feb 17, 2020
Copy link
Member

alexr00 left a comment

Looks good, thanks for the PR!

@alexr00 alexr00 merged commit d3cc58d into microsoft:master Feb 20, 2020
4 checks passed
4 checks passed
linux
Details
windows
Details
darwin
Details
license/cla All CLA requirements met.
Details
@jlittorin

This comment has been minimized.

Copy link
Contributor Author

jlittorin commented Feb 21, 2020

Looks good, thanks for the PR!

Thanks, @alexr00! Since this changes the API slightly I should also update the corresponding documentation, I guess. Can I just go do that in the wiki-repo? How is that synced with releases of the app?

@alexr00

This comment has been minimized.

Copy link
Member

alexr00 commented Feb 21, 2020

If you would update the docs that would be awesome. Only this file should need to be changed: https://github.com/microsoft/vscode-docs/blob/538606e34aa67fd266cfcce79a3830c92b093e32/docs/editor/variables-reference.md#L103-L104
You can use the vnext branch as your base for the PR. We merge around the same time as releasing VS Code. If you can @ mention me in the PR description then I'll see the it faster too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.