Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed Open/Save dialog title on public VSCode Proposed API #90493

Merged
merged 2 commits into from Feb 19, 2020

Conversation

@GustavoASC
Copy link
Contributor

GustavoASC commented Feb 11, 2020

This PR fixes #82871.
Now open/save dialog title is exposed on public VSCode Proposed API.

I've tested on Ubuntu 19.10 with an extension which invokes showSaveDialog() and showOpenDialog() methods. Here's an usage example:

image

The example below shows My open title on the top of Open Dialog.

image

Note: on this version of Ubuntu the Save Dialog title is not shown, but it's an OS-related behaviour.
Every save dialog of VSCode running on Ubuntu 19.10 ignores the specified title as can be seen on 'File -> Save Workspace As...' (On Windows it shows 'Save Workspace' but on Ubuntu no title is shown).

@aeschli

This comment has been minimized.

Copy link
Contributor

aeschli commented Feb 17, 2020

Change looks good to me.

@GustavoASC

This comment has been minimized.

Copy link
Contributor Author

GustavoASC commented Feb 19, 2020

@alexr00 do you agree with these changes?

@alexr00

This comment has been minimized.

Copy link
Member

alexr00 commented Feb 19, 2020

Yes, I just haven't had a chance to merge this yet :)

@alexr00 alexr00 added this to the February 2020 milestone Feb 19, 2020
@alexr00 alexr00 merged commit 4957d8d into microsoft:master Feb 19, 2020
5 checks passed
5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20200219.59 succeeded
Details
license/cla All CLA requirements met.
Details
@alexr00

This comment has been minimized.

Copy link
Member

alexr00 commented Feb 19, 2020

Thank you for the PR!

@GustavoASC GustavoASC mentioned this pull request Feb 21, 2020
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.