Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run active file in terminal not wrapping with quotes #90847

Merged
merged 1 commit into from Feb 19, 2020

Conversation

@dormesica
Copy link
Contributor

dormesica commented Feb 17, 2020

Wait for processReady event before runnigs file.

This PR fixes #90415

Fix #90415.
Wait for processReady event before runnigs file.
@dormesica dormesica requested a review from Tyriar Feb 17, 2020
@dormesica dormesica changed the title Fix #90415. [WIP] Fix #90415. Feb 17, 2020
@dormesica

This comment has been minimized.

Copy link
Contributor Author

dormesica commented Feb 17, 2020

I have no idea why these piplines fail.
It seems like the Monaco Editor checks fail but I haven't touched it.

@nrayburn-tech

This comment has been minimized.

Copy link
Contributor

nrayburn-tech commented Feb 18, 2020

@dormesica Chances are that the branch you were working on was failing already. It looks like the current master is passing, so if you update your branch to be in sync with master, your test should pass as well.

Copy link
Member

Tyriar left a comment

Is the reason this was failing because instance.shellLaunchConfig was not accurate until instance.processReady? Is the repro to run this without a terminal opened?

@dormesica

This comment has been minimized.

Copy link
Contributor Author

dormesica commented Feb 18, 2020

@nrayburn-tech Just before submitting the merge request I pull the master brach and rebase my branch onto it. I'll try again.

@Tyriar The reason for the bug was indeed that instance.shellLaunchConfig was not ready. I was looking for a way to dermine when the TermianlInstance is ready and I encountered the processReady property.
It could be that I got the purpose of this property wrong, so I labeled the PR as WIP, in that case my bad 😬.

And yes, in order to reproduce the bug close all terminals and click on Run Active File.

@Tyriar
Tyriar approved these changes Feb 19, 2020
Copy link
Member

Tyriar left a comment

Works great thanks! I created #90993 for me to follow up on maybe doing some refactoring to avoid this problem happening outside of terminalInstance.

@Tyriar Tyriar changed the title [WIP] Fix #90415. Fix run active file in terminal not wrapping with quotes Feb 19, 2020
@Tyriar Tyriar added this to the February 2020 milestone Feb 19, 2020
@Tyriar Tyriar merged commit d793ae6 into microsoft:master Feb 19, 2020
1 of 5 checks passed
1 of 5 checks passed
linux linux
Details
windows windows
Details
darwin darwin
Details
VS Code #20200217.73 failed
Details
license/cla All CLA requirements met.
@dormesica dormesica deleted the dormesica:Fix-#90415 branch Feb 19, 2020
@dormesica dormesica restored the dormesica:Fix-#90415 branch Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.