Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address feedback for reset editor.lineNumbers after disabling zen mode #90910

Merged
merged 1 commit into from Feb 19, 2020

Conversation

@jeanp413
Copy link
Contributor

jeanp413 commented Feb 18, 2020

This PR addresses feedback given in #90822

@isidorn @jeanp413 not a big fan of how this ends up adding a new field to the layout.ts class which is only used by zen mode. Why can this not be added to the transitionDisposables set that is called each time zen mode changes? There should be a disposable for each editor that gets the line number updated, no?

@isidorn Not sure if I'm not understanding something but transitionDisposables just have an add and clear methods, and we need a way to keep track if an editor have already been added to avoid adding it multiple times so I just moved editorWidgetSet inside this.state.zenMode object and used the onDidDispose event to remove the disposed editors from the set.

Let me know if I'm missing something

@isidorn isidorn self-assigned this Feb 19, 2020
@isidorn

This comment has been minimized.

Copy link
Contributor

isidorn commented Feb 19, 2020

Looks good, and behaves great. Thus merging in. Thanks for providing great PRs!
☀️

@isidorn isidorn merged commit 974d271 into microsoft:master Feb 19, 2020
5 checks passed
5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20200218.61 succeeded
Details
license/cla All CLA requirements met.
Details
@isidorn isidorn added this to the February 2020 milestone Feb 19, 2020
@jeanp413 jeanp413 deleted the jeanp413:zen-mode-linenumbers-feedback branch Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.