Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a small bug of JsonValidation #91237

Merged
merged 1 commit into from Feb 25, 2020
Merged

Fix a small bug of JsonValidation #91237

merged 1 commit into from Feb 25, 2020

Conversation

@PMExtra
Copy link
Contributor

PMExtra commented Feb 23, 2020

The origin condition expression (!strings.startsWith(uri, 'https:/') && strings.startsWith(uri, 'https:/')) is always false.
According to the context code, it should be (!strings.startsWith(uri, 'http://') && !strings.startsWith(uri, 'https://')) instead.

The origin condition expression `(!strings.startsWith(uri, 'https:/') && strings.startsWith(uri, 'https:/'))` is always false.
According to the context code, it should be `(!strings.startsWith(uri, 'http://') && !strings.startsWith(uri, 'https://'))` instead.
@aeschli aeschli merged commit 8d7d2f6 into microsoft:master Feb 25, 2020
6 checks passed
6 checks passed
linux
Details
windows
Details
darwin
Details
monaco
Details
VS Code #20200223.25 succeeded
Details
license/cla All CLA requirements met.
@aeschli aeschli added this to the February 2020 milestone Feb 25, 2020
@aeschli

This comment has been minimized.

Copy link
Contributor

aeschli commented Feb 25, 2020

Thanks @PMExtra !
In fact not only http and https URIs are allowed, but also URIs from vscode resource providers. I'm going to update the check.

@PMExtra

This comment has been minimized.

Copy link
Contributor Author

PMExtra commented Feb 26, 2020

@aeschli Yes, I considered this situation.

This is the latest else if branch, the relative path (extension resources) has been handled before it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.