Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings UI: Add separator for sync setting #91461

Merged
merged 2 commits into from Feb 27, 2020

Conversation

@lgordey
Copy link

lgordey commented Feb 25, 2020

This PR fixes #91395

Gordey Levchenko Gordey Levchenko
@roblourens roblourens added this to the February 2020 milestone Feb 26, 2020
@roblourens roblourens self-assigned this Feb 26, 2020
@@ -1205,6 +1205,7 @@ export class SettingTreeRenderers {
new Separator(),
this._instantiationService.createInstance(CopySettingIdAction),
this._instantiationService.createInstance(CopySettingAsJSONAction),
new Separator(),

This comment has been minimized.

Copy link
@roblourens

roblourens Feb 26, 2020

Member

This shouldn't be added unless the action after it is present. Otherwise there will be a lone separator at the end of the list (at least on windows with the custom context menu)

@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Feb 27, 2020

I made the change so I can get this in today - thanks for the PR!

@roblourens roblourens merged commit cffd0c5 into microsoft:master Feb 27, 2020
4 of 5 checks passed
4 of 5 checks passed
linux
Details
windows
Details
darwin darwin
Details
monaco
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.