Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved documentation of 'title' parameter on VSCode Proposed API #91633

Merged
merged 1 commit into from Feb 27, 2020

Conversation

@GustavoASC
Copy link
Contributor

GustavoASC commented Feb 26, 2020

This PR is related to #82871 and #91153.

Now the title parameter documentation indicates that depending on the underlying operating system the title might be ignored, since some systems do not present title on open/save dialogs.

Copy link
Member

alexr00 left a comment

@GustavoASC thanks for staying involved in this change!

@alexr00 alexr00 added this to the February 2020 milestone Feb 27, 2020
@alexr00 alexr00 merged commit 9ee247f into microsoft:master Feb 27, 2020
6 checks passed
6 checks passed
linux
Details
windows
Details
darwin
Details
monaco
Details
VS Code #20200226.67 succeeded
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.