Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurations field to launch.json, workspace.json or .code-workspace when it does not exist #95488

Merged

Conversation

xisui-MSFT
Copy link
Contributor

This PR fixes #94844

This PR fixes more than the work item. After investigating I found that suggestions won't show up under single root mode as well if configurations field doesn't exist. To fix this, append configurations (or launch -> configurations) field to launch.json, workspace.json, or .code-workspace file before providing debugging options.

@isidorn
Copy link
Contributor

isidorn commented Apr 17, 2020

@xisui-MSFT great work. Love it!
Merging in and thank you very much ☀️ 🍻

@isidorn isidorn merged commit 958a942 into microsoft:master Apr 17, 2020
@isidorn isidorn added this to the April 2020 milestone Apr 17, 2020
@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Apr 17, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configuration (workspace) doesn't open debug configuration list
2 participants