diff --git a/.yarnrc b/.yarnrc index c3c11fbeb9198..d86b284e83e63 100644 --- a/.yarnrc +++ b/.yarnrc @@ -1,3 +1,3 @@ disturl "https://atom.io/download/electron" -target "7.2.2" +target "7.2.4" runtime "electron" diff --git a/cgmanifest.json b/cgmanifest.json index 2d5e8a2d66cb4..09478ca403e6a 100644 --- a/cgmanifest.json +++ b/cgmanifest.json @@ -60,12 +60,12 @@ "git": { "name": "electron", "repositoryUrl": "https://github.com/electron/electron", - "commitHash": "959e80cc53cbebf8eb1d62eb2d14fa8fd86b0394" + "commitHash": "0552e0d5de46ffa3b481d741f1db5c779e201565" } }, "isOnlyProductionDependency": true, "license": "MIT", - "version": "7.2.2" + "version": "7.2.4" }, { "component": { diff --git a/extensions/configuration-editing/schemas/devContainer.schema.json b/extensions/configuration-editing/schemas/devContainer.schema.json index 9cb171915fc62..5a69d57057b02 100644 --- a/extensions/configuration-editing/schemas/devContainer.schema.json +++ b/extensions/configuration-editing/schemas/devContainer.schema.json @@ -282,33 +282,42 @@ ] } }, - "allOf": [ + "oneOf": [ { - "oneOf": [ + "allOf": [ { - "allOf": [ + "oneOf": [ { - "oneOf": [ + "allOf": [ { - "$ref": "#/definitions/dockerfileContainer" + "oneOf": [ + { + "$ref": "#/definitions/dockerfileContainer" + }, + { + "$ref": "#/definitions/imageContainer" + } + ] }, { - "$ref": "#/definitions/imageContainer" + "$ref": "#/definitions/nonComposeBase" } ] }, { - "$ref": "#/definitions/nonComposeBase" + "$ref": "#/definitions/composeContainer" } ] }, { - "$ref": "#/definitions/composeContainer" + "$ref": "#/definitions/devContainerCommon" } ] }, { - "$ref": "#/definitions/devContainerCommon" + "type": "object", + "$ref": "#/definitions/devContainerCommon", + "additionalProperties": false } ] } diff --git a/extensions/git/src/askpass.ts b/extensions/git/src/askpass.ts index ad1b5f3a79152..7fc29a371ad91 100644 --- a/extensions/git/src/askpass.ts +++ b/extensions/git/src/askpass.ts @@ -3,7 +3,7 @@ * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ -import { window, InputBoxOptions, Uri, OutputChannel, Disposable } from 'vscode'; +import { window, InputBoxOptions, Uri, OutputChannel, Disposable, workspace } from 'vscode'; import { IDisposable, EmptyDisposable, toDisposable } from './util'; import * as path from 'path'; import { IIPCHandler, IIPCServer, createIPCServer } from './ipc/ipcServer'; @@ -31,6 +31,13 @@ export class Askpass implements IIPCHandler { } async handle({ request, host }: { request: string, host: string }): Promise { + const config = workspace.getConfiguration('git', null); + const enabled = config.get('enabled'); + + if (!enabled) { + return ''; + } + const uri = Uri.parse(host); const authority = uri.authority.replace(/^.*@/, ''); const password = /password/i.test(request); diff --git a/extensions/git/src/github.ts b/extensions/git/src/github.ts index bc2f816e52b4b..7020d6788d59c 100644 --- a/extensions/git/src/github.ts +++ b/extensions/git/src/github.ts @@ -56,7 +56,8 @@ export class GithubCredentialProviderManager { } private refresh(): void { - this.enabled = workspace.getConfiguration('git', null).get('githubAuthentication', true); + const config = workspace.getConfiguration('git', null); + this.enabled = config.get('enabled', true) && config.get('githubAuthentication', true); } dispose(): void { diff --git a/extensions/git/src/terminal.ts b/extensions/git/src/terminal.ts index c5b9eb81fbb38..2eda93151d231 100644 --- a/extensions/git/src/terminal.ts +++ b/extensions/git/src/terminal.ts @@ -34,7 +34,8 @@ export class TerminalEnvironmentManager { } private refresh(): void { - this.enabled = workspace.getConfiguration('git', null).get('terminalAuthentication', true); + const config = workspace.getConfiguration('git', null); + this.enabled = config.get('enabled', true) && config.get('terminalAuthentication', true); } dispose(): void { diff --git a/package.json b/package.json index 9b1f739894e2d..8836b634f38c6 100644 --- a/package.json +++ b/package.json @@ -101,7 +101,7 @@ "css-loader": "^3.2.0", "debounce": "^1.0.0", "deemon": "^1.4.0", - "electron": "7.2.2", + "electron": "7.2.4", "eslint": "6.8.0", "eslint-plugin-jsdoc": "^19.1.0", "event-stream": "3.3.4", diff --git a/src/vs/base/browser/ui/list/listView.ts b/src/vs/base/browser/ui/list/listView.ts index cea7064b56364..b76361c2695c7 100644 --- a/src/vs/base/browser/ui/list/listView.ts +++ b/src/vs/base/browser/ui/list/listView.ts @@ -278,7 +278,8 @@ export class ListView implements ISpliceable, IDisposable { this.rowsContainer = document.createElement('div'); this.rowsContainer.className = 'monaco-list-rows'; - if (options.transformOptimization) { + const transformOptimization = getOrDefault(options, o => o.transformOptimization, DefaultOptions.transformOptimization); + if (transformOptimization) { this.rowsContainer.style.transform = 'translate3d(0px, 0px, 0px)'; } diff --git a/src/vs/code/electron-browser/proxy/auth.html b/src/vs/code/electron-browser/proxy/auth.html index 5ef195878cafc..76d22eb491a57 100644 --- a/src/vs/code/electron-browser/proxy/auth.html +++ b/src/vs/code/electron-browser/proxy/auth.html @@ -5,7 +5,7 @@ + content="default-src 'none'; img-src 'self' https: data:; media-src 'none'; child-src 'self'; object-src 'self'; script-src 'self' 'unsafe-inline'; style-src 'self' 'unsafe-inline'; connect-src 'self' https:; font-src 'self' https:;">