From 25b89f56f7ed92bd2743c3954f2f90f2e599735f Mon Sep 17 00:00:00 2001 From: Sarabjot Singh Date: Wed, 19 Jun 2019 15:24:32 +0530 Subject: [PATCH 1/7] Cleaning the remaining set of dependencies for source build. a. Microsoft.Build.Framework and Microsoft.Build.Utilities.Core to source built version: 16.0.461 b. Microsoft.Extensions.DependencyModel to source built version: 3.0.0-preview4-27615-11 c. Removed the redundant reference to Microsoft.Internal.Dia.Interop d. Adding check for source build for StyleCop.Analyzers --- scripts/build/TestPlatform.targets | 2 +- .../Microsoft.TestPlatform.Build.csproj | 4 ++-- .../Microsoft.TestPlatform.CoreUtilities.csproj | 3 --- .../Microsoft.TestPlatform.PlatformAbstractions.csproj | 7 ++----- .../Microsoft.TestPlatform.TestHostProvider.csproj | 2 +- src/package/external/external.csproj | 8 ++++---- src/package/nuspec/TestPlatform.TestHost.nuspec | 2 +- .../Microsoft.TestPlatform.Build.UnitTests.csproj | 4 ++-- 8 files changed, 13 insertions(+), 19 deletions(-) diff --git a/scripts/build/TestPlatform.targets b/scripts/build/TestPlatform.targets index a42957b0de..6a3e102719 100644 --- a/scripts/build/TestPlatform.targets +++ b/scripts/build/TestPlatform.targets @@ -5,7 +5,7 @@ - + 1.0.1 All diff --git a/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj b/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj index d8198dc3c6..19884e9456 100644 --- a/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj +++ b/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj @@ -32,10 +32,10 @@ - 15.1.548 + 16.0.461 - 15.1.548 + 16.0.461 diff --git a/src/Microsoft.TestPlatform.CoreUtilities/Microsoft.TestPlatform.CoreUtilities.csproj b/src/Microsoft.TestPlatform.CoreUtilities/Microsoft.TestPlatform.CoreUtilities.csproj index cfdac10080..95cf3898a0 100644 --- a/src/Microsoft.TestPlatform.CoreUtilities/Microsoft.TestPlatform.CoreUtilities.csproj +++ b/src/Microsoft.TestPlatform.CoreUtilities/Microsoft.TestPlatform.CoreUtilities.csproj @@ -13,9 +13,6 @@ - - 14.0.0 - diff --git a/src/Microsoft.TestPlatform.PlatformAbstractions/Microsoft.TestPlatform.PlatformAbstractions.csproj b/src/Microsoft.TestPlatform.PlatformAbstractions/Microsoft.TestPlatform.PlatformAbstractions.csproj index c8a06af90a..3c7a1961b4 100644 --- a/src/Microsoft.TestPlatform.PlatformAbstractions/Microsoft.TestPlatform.PlatformAbstractions.csproj +++ b/src/Microsoft.TestPlatform.PlatformAbstractions/Microsoft.TestPlatform.PlatformAbstractions.csproj @@ -1,4 +1,4 @@ - + ..\..\ @@ -7,7 +7,7 @@ Microsoft.TestPlatform.PlatformAbstractions netstandard1.0;netcoreapp1.0;net451;uap10.0 - netstandard1.0;netcoreapp1.0;net451 + netstandard1.0;netcoreapp1.0 false true @@ -59,9 +59,6 @@ - - 14.0.0 - diff --git a/src/Microsoft.TestPlatform.TestHostProvider/Microsoft.TestPlatform.TestHostProvider.csproj b/src/Microsoft.TestPlatform.TestHostProvider/Microsoft.TestPlatform.TestHostProvider.csproj index af0a208711..6e1dd976fc 100644 --- a/src/Microsoft.TestPlatform.TestHostProvider/Microsoft.TestPlatform.TestHostProvider.csproj +++ b/src/Microsoft.TestPlatform.TestHostProvider/Microsoft.TestPlatform.TestHostProvider.csproj @@ -22,7 +22,7 @@ - 1.0.3 + 3.0.0-preview4-27615-11 diff --git a/src/package/external/external.csproj b/src/package/external/external.csproj index 0c318574e1..a9cb55a539 100644 --- a/src/package/external/external.csproj +++ b/src/package/external/external.csproj @@ -81,15 +81,15 @@ 15.6.815-master284DF69C All - - - - + 1.0.1 All + + diff --git a/src/package/nuspec/TestPlatform.TestHost.nuspec b/src/package/nuspec/TestPlatform.TestHost.nuspec index 6e324849b6..9beac8a407 100644 --- a/src/package/nuspec/TestPlatform.TestHost.nuspec +++ b/src/package/nuspec/TestPlatform.TestHost.nuspec @@ -17,7 +17,7 @@ - + diff --git a/test/Microsoft.TestPlatform.Build.UnitTests/Microsoft.TestPlatform.Build.UnitTests.csproj b/test/Microsoft.TestPlatform.Build.UnitTests/Microsoft.TestPlatform.Build.UnitTests.csproj index 3415f2af92..cb836e0797 100644 --- a/test/Microsoft.TestPlatform.Build.UnitTests/Microsoft.TestPlatform.Build.UnitTests.csproj +++ b/test/Microsoft.TestPlatform.Build.UnitTests/Microsoft.TestPlatform.Build.UnitTests.csproj @@ -19,10 +19,10 @@ - 15.1.548 + 16.0.461 - 15.1.548 + 16.0.461 From 708687637d162f2b210113629e64c3184c882e2d Mon Sep 17 00:00:00 2001 From: Sarabjot Singh Date: Wed, 19 Jun 2019 18:54:48 +0530 Subject: [PATCH 2/7] Fixing the failures --- scripts/verify-nupkgs.ps1 | 6 +++--- .../Microsoft.TestPlatform.Build.csproj | 3 ++- .../Microsoft.TestPlatform.CoreUtilities.csproj | 3 +++ .../Microsoft.TestPlatform.PlatformAbstractions.csproj | 3 +++ src/package/nuspec/Microsoft.TestPlatform.Portable.nuspec | 2 -- src/package/nuspec/Microsoft.TestPlatform.nuspec | 1 - src/package/nuspec/TestPlatform.Build.nuspec | 6 +++--- .../Microsoft.TestPlatform.Build.UnitTests.csproj | 2 +- 8 files changed, 15 insertions(+), 11 deletions(-) diff --git a/scripts/verify-nupkgs.ps1 b/scripts/verify-nupkgs.ps1 index 8c31c0900e..e27b3503f1 100644 --- a/scripts/verify-nupkgs.ps1 +++ b/scripts/verify-nupkgs.ps1 @@ -14,12 +14,12 @@ function Verify-Nuget-Packages($packageDirectory) Write-Log "Starting Verify-Nuget-Packages." $expectedNumOfFiles = @{"Microsoft.CodeCoverage" = 29; "Microsoft.NET.Test.Sdk" = 13; - "Microsoft.TestPlatform" = 422; + "Microsoft.TestPlatform" = 421; "Microsoft.TestPlatform.Build" = 19; - "Microsoft.TestPlatform.CLI" = 302; + "Microsoft.TestPlatform.CLI" = 303; "Microsoft.TestPlatform.Extensions.TrxLogger" = 33; "Microsoft.TestPlatform.ObjectModel" = 65; - "Microsoft.TestPlatform.Portable" = 472; + "Microsoft.TestPlatform.Portable" = 470; "Microsoft.TestPlatform.TestHost" = 140; "Microsoft.TestPlatform.TranslationLayer" = 121} diff --git a/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj b/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj index 19884e9456..c10153d5dd 100644 --- a/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj +++ b/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj @@ -5,8 +5,9 @@ + 2.0.0 Microsoft.TestPlatform.Build - netstandard1.3 + netstandard2.0 true diff --git a/src/Microsoft.TestPlatform.CoreUtilities/Microsoft.TestPlatform.CoreUtilities.csproj b/src/Microsoft.TestPlatform.CoreUtilities/Microsoft.TestPlatform.CoreUtilities.csproj index 95cf3898a0..cfdac10080 100644 --- a/src/Microsoft.TestPlatform.CoreUtilities/Microsoft.TestPlatform.CoreUtilities.csproj +++ b/src/Microsoft.TestPlatform.CoreUtilities/Microsoft.TestPlatform.CoreUtilities.csproj @@ -13,6 +13,9 @@ + + 14.0.0 + diff --git a/src/Microsoft.TestPlatform.PlatformAbstractions/Microsoft.TestPlatform.PlatformAbstractions.csproj b/src/Microsoft.TestPlatform.PlatformAbstractions/Microsoft.TestPlatform.PlatformAbstractions.csproj index 3c7a1961b4..d26b12cd0a 100644 --- a/src/Microsoft.TestPlatform.PlatformAbstractions/Microsoft.TestPlatform.PlatformAbstractions.csproj +++ b/src/Microsoft.TestPlatform.PlatformAbstractions/Microsoft.TestPlatform.PlatformAbstractions.csproj @@ -59,6 +59,9 @@ + + 14.0.0 + diff --git a/src/package/nuspec/Microsoft.TestPlatform.Portable.nuspec b/src/package/nuspec/Microsoft.TestPlatform.Portable.nuspec index 16b91c6835..636d97af93 100644 --- a/src/package/nuspec/Microsoft.TestPlatform.Portable.nuspec +++ b/src/package/nuspec/Microsoft.TestPlatform.Portable.nuspec @@ -21,7 +21,6 @@ - @@ -223,7 +222,6 @@ - diff --git a/src/package/nuspec/Microsoft.TestPlatform.nuspec b/src/package/nuspec/Microsoft.TestPlatform.nuspec index 5611d9b658..9ca82f4d67 100644 --- a/src/package/nuspec/Microsoft.TestPlatform.nuspec +++ b/src/package/nuspec/Microsoft.TestPlatform.nuspec @@ -96,7 +96,6 @@ - diff --git a/src/package/nuspec/TestPlatform.Build.nuspec b/src/package/nuspec/TestPlatform.Build.nuspec index fd7941f8fe..92c0d9d73b 100644 --- a/src/package/nuspec/TestPlatform.Build.nuspec +++ b/src/package/nuspec/TestPlatform.Build.nuspec @@ -1,4 +1,4 @@ - + Microsoft.TestPlatform.Build @@ -15,10 +15,10 @@ vstest visual-studio unittest testplatform mstest microsoft test testing - + - + diff --git a/test/Microsoft.TestPlatform.Build.UnitTests/Microsoft.TestPlatform.Build.UnitTests.csproj b/test/Microsoft.TestPlatform.Build.UnitTests/Microsoft.TestPlatform.Build.UnitTests.csproj index cb836e0797..72da5d2a07 100644 --- a/test/Microsoft.TestPlatform.Build.UnitTests/Microsoft.TestPlatform.Build.UnitTests.csproj +++ b/test/Microsoft.TestPlatform.Build.UnitTests/Microsoft.TestPlatform.Build.UnitTests.csproj @@ -7,7 +7,7 @@ Exe - netcoreapp1.0 + netcoreapp2.1 Microsoft.TestPlatform.Build.UnitTests true true From a169930cca5dfddb5333d0c98865b8f6eb130b1b Mon Sep 17 00:00:00 2001 From: Sarabjot Singh Date: Thu, 20 Jun 2019 22:09:36 +0530 Subject: [PATCH 3/7] Adding System.Memory and System.Runtime.CompilerServices.Unsafe to portable package --- src/package/nuspec/Microsoft.TestPlatform.Portable.nuspec | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/package/nuspec/Microsoft.TestPlatform.Portable.nuspec b/src/package/nuspec/Microsoft.TestPlatform.Portable.nuspec index 636d97af93..5236d5b79e 100644 --- a/src/package/nuspec/Microsoft.TestPlatform.Portable.nuspec +++ b/src/package/nuspec/Microsoft.TestPlatform.Portable.nuspec @@ -223,6 +223,8 @@ + + From 9e2cedbd80670ad6b5dd68312f70fadf0f8f0a35 Mon Sep 17 00:00:00 2001 From: Sarabjot Singh Date: Thu, 20 Jun 2019 22:16:00 +0530 Subject: [PATCH 4/7] Correcting the number of files. --- scripts/verify-nupkgs.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/verify-nupkgs.ps1 b/scripts/verify-nupkgs.ps1 index e27b3503f1..7b38680665 100644 --- a/scripts/verify-nupkgs.ps1 +++ b/scripts/verify-nupkgs.ps1 @@ -19,7 +19,7 @@ function Verify-Nuget-Packages($packageDirectory) "Microsoft.TestPlatform.CLI" = 303; "Microsoft.TestPlatform.Extensions.TrxLogger" = 33; "Microsoft.TestPlatform.ObjectModel" = 65; - "Microsoft.TestPlatform.Portable" = 470; + "Microsoft.TestPlatform.Portable" = 472; "Microsoft.TestPlatform.TestHost" = 140; "Microsoft.TestPlatform.TranslationLayer" = 121} From d79430ad3daea26d684f02c4bf786ef15198f7ba Mon Sep 17 00:00:00 2001 From: Sarabjot Singh Date: Fri, 21 Jun 2019 14:50:40 +0530 Subject: [PATCH 5/7] Made the packages configurable via the props file. --- scripts/build/TestPlatform.Dependencies.props | 7 +++++++ .../Microsoft.TestPlatform.Build.csproj | 8 ++------ .../Microsoft.TestPlatform.TestHostProvider.csproj | 4 +--- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/scripts/build/TestPlatform.Dependencies.props b/scripts/build/TestPlatform.Dependencies.props index 062d67f0ff..30fcabab0e 100644 --- a/scripts/build/TestPlatform.Dependencies.props +++ b/scripts/build/TestPlatform.Dependencies.props @@ -24,5 +24,12 @@ 4.7.63 16.0.0-preview-2148743 + 16.0.461 + $(MicrosoftBuildPackageVersion) + $(MicrosoftBuildPackageVersion) + 3.0.0-preview4-27615-11 + + + diff --git a/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj b/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj index c10153d5dd..d89ff11ad2 100644 --- a/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj +++ b/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj @@ -32,12 +32,8 @@ - - 16.0.461 - - - 16.0.461 - + + diff --git a/src/Microsoft.TestPlatform.TestHostProvider/Microsoft.TestPlatform.TestHostProvider.csproj b/src/Microsoft.TestPlatform.TestHostProvider/Microsoft.TestPlatform.TestHostProvider.csproj index 6e1dd976fc..d019d307c8 100644 --- a/src/Microsoft.TestPlatform.TestHostProvider/Microsoft.TestPlatform.TestHostProvider.csproj +++ b/src/Microsoft.TestPlatform.TestHostProvider/Microsoft.TestPlatform.TestHostProvider.csproj @@ -21,9 +21,7 @@ - - 3.0.0-preview4-27615-11 - + From 0d01c84711c9a8126016b08d1c4f4a9e39b972b0 Mon Sep 17 00:00:00 2001 From: Sarabjot Singh Date: Fri, 21 Jun 2019 14:54:12 +0530 Subject: [PATCH 6/7] Fixing versions in the unit test project as well. --- .../Microsoft.TestPlatform.Build.UnitTests.csproj | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/test/Microsoft.TestPlatform.Build.UnitTests/Microsoft.TestPlatform.Build.UnitTests.csproj b/test/Microsoft.TestPlatform.Build.UnitTests/Microsoft.TestPlatform.Build.UnitTests.csproj index 72da5d2a07..b73de65a95 100644 --- a/test/Microsoft.TestPlatform.Build.UnitTests/Microsoft.TestPlatform.Build.UnitTests.csproj +++ b/test/Microsoft.TestPlatform.Build.UnitTests/Microsoft.TestPlatform.Build.UnitTests.csproj @@ -18,12 +18,8 @@ - - 16.0.461 - - - 16.0.461 - + + From e3aab3b8c9f063fa965f70280b018d465b28bfdf Mon Sep 17 00:00:00 2001 From: Sarabjot Singh Date: Fri, 21 Jun 2019 15:40:23 +0530 Subject: [PATCH 7/7] Removing redundant dependency in the testhost nuspec --- src/package/nuspec/TestPlatform.TestHost.nuspec | 1 - 1 file changed, 1 deletion(-) diff --git a/src/package/nuspec/TestPlatform.TestHost.nuspec b/src/package/nuspec/TestPlatform.TestHost.nuspec index 9beac8a407..619e7efa68 100644 --- a/src/package/nuspec/TestPlatform.TestHost.nuspec +++ b/src/package/nuspec/TestPlatform.TestHost.nuspec @@ -17,7 +17,6 @@ -