Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade externals - tests for test platform nuget #2649

Merged
merged 5 commits into from Nov 23, 2020

Conversation

jakubch1
Copy link
Member

@jakubch1 jakubch1 commented Nov 23, 2020

Description

We found out that TraceDataCollector depends on Coverage.Interop.dll so previous deletion of Coverage.Interop.dll results in not be able to get code coverage. This was detected by manual test. PR is also adding automatic test to check TP + TraceDataCollector (from VS) integration.

Related issue

Kindly link any related issues. E.g. Fixes #xyz.

Copy link
Member

@cvpoienaru cvpoienaru left a comment

LGTM

@nohwnd
Copy link
Member

nohwnd commented Nov 23, 2020

Could you fix the description, please? I don't understand what was this meant to do. And would like to know in the future, if it is identified in some regression.

@msftbot
Copy link
Contributor

msftbot bot commented Nov 23, 2020

Hello @cvpoienaru!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@jakubch1
Copy link
Member Author

jakubch1 commented Nov 23, 2020

Could you fix the description, please? I don't understand what was this meant to do. And would like to know in the future, if it is identified in some regression.

Done

@jakubch1 jakubch1 merged commit b6cdf7d into microsoft:master Nov 23, 2020
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants