Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort when init and run messages fail to process #2887

Merged
merged 1 commit into from May 4, 2021

Conversation

@Haplois
Copy link
Member

@Haplois Haplois commented May 4, 2021

  • Abort when init and run messages fail to process, usually on deserialization, to prevent the host from hanging
  • Send the message via the abort handler when we abort the run

Cherrypicked from #2857 with an extra sauce of localization.

* Abort when init and run messages fail to process, usually on deserialization, to prevent the host from hanging
* Send the message via the abort handler when we abort the run
@Haplois Haplois requested a review from cvpoienaru May 4, 2021
@microsoft microsoft deleted a comment from msftbot bot May 4, 2021
@Haplois Haplois removed the auto-merge label May 4, 2021
Copy link
Member

@cvpoienaru cvpoienaru left a comment

LGTM

@Haplois Haplois merged commit 2acc8af into microsoft:rel/16.10 May 4, 2021
7 checks passed
7 checks passed
@msftbot
auto-merge.config.enforce No dynamic merge policies are applicable.
@microsoft-cla
license/cla All CLA requirements met.
Details
@azure-pipelines
microsoft.vstest.pr Build #20210504.3 succeeded
Details
@azure-pipelines
microsoft.vstest.pr (OtherOSes Ubuntu_18_04) OtherOSes Ubuntu_18_04 succeeded
Details
@azure-pipelines
microsoft.vstest.pr (OtherOSes macOS_10_15_Catalina) OtherOSes macOS_10_15_Catalina succeeded
Details
@azure-pipelines
microsoft.vstest.pr (Windows) Windows succeeded
Details
@azure-pipelines
microsoft.vstest.pr (WindowsAcceptance) WindowsAcceptance succeeded
Details
@Haplois Haplois deleted the Haplois:pre/16.10 branch May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants