Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix common.lib.ps1 use correct dotnet on ARM64 devices. #3986

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

Haplois
Copy link
Contributor

@Haplois Haplois commented Sep 1, 2022

Build script updated to work on ARM64 devices natively.

@Haplois Haplois enabled auto-merge (squash) September 1, 2022 12:35
$x64Architecture = "x64"
if ($env:PROCESSOR_ARCHITECTURE -eq "ARM64")
{
$x64Architecture = "arm64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about x86, shall we have some similar logic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, I don't have a device to test it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it as-is for now then.

@Haplois Haplois merged commit 2372631 into main Sep 1, 2022
@Haplois Haplois deleted the dev/haplois/build-on-arm branch September 1, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants