New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for CollectSourceInformation flag in runsettings #905

Merged
merged 9 commits into from Jul 6, 2017

Conversation

Projects
None yet
4 participants
@Shyam-Gupta
Member

Shyam-Gupta commented Jun 30, 2017

  1. If CollectSourceInformation is already present in the run settings then it will not get updated
  2. If it is not present then it will default to value of DesignMode flag and will be added to run settings
  3. Added automated tests
@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Jun 30, 2017

@Shyam-Gupta,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

msftclas commented Jun 30, 2017

@Shyam-Gupta,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Shyam Gupta
Show outdated Hide outdated src/Microsoft.TestPlatform.ObjectModel/RunSettings/RunConfiguration.cs
@@ -362,6 +385,8 @@ public bool ResultsDirectorySet
Justification = "XmlDocument.XmlResolver is not available in core. Suppress until fxcop issue is fixed.")]
public override XmlElement ToXml()
{
System.Diagnostics.Debugger.Launch();

This comment has been minimized.

@Faizan2304

Faizan2304 Jul 4, 2017

Contributor

Please remove this.

@Faizan2304

Faizan2304 Jul 4, 2017

Contributor

Please remove this.

Shyam Gupta

@Shyam-Gupta Shyam-Gupta self-assigned this Jul 4, 2017

Show outdated Hide outdated src/Microsoft.TestPlatform.ObjectModel/RunSettings/RunConfiguration.cs
@@ -85,6 +90,7 @@ public RunConfiguration() : base(Constants.RunConfigurationSettingsName)
this.disableAppDomain = false;
this.disableParallelization = false;
this.designMode = false;
this.shouldCollectSourceInformation = this.designMode;

This comment has been minimized.

@harshjain2

harshjain2 Jul 4, 2017

Member

nit : Replace this.shouldCollectSourceInformation = this.designMode; with this.shouldCollectSourceInformation = false;

@harshjain2

harshjain2 Jul 4, 2017

Member

nit : Replace this.shouldCollectSourceInformation = this.designMode; with this.shouldCollectSourceInformation = false;

This comment has been minimized.

@Shyam-Gupta

Shyam-Gupta Jul 5, 2017

Member

Done.

@Shyam-Gupta
// Navigator should be at Root of runsettings xml, attempt to move to /RunSettings/RunConfiguration
if (!runSettingsNavigator.MoveToChild(RunSettingsNodeName, string.Empty) ||
!runSettingsNavigator.MoveToChild(RunConfigurationNodeName, string.Empty))
!runSettingsNavigator.MoveToChild(RunConfigurationNodeName, string.Empty))

This comment has been minimized.

@harshjain2

harshjain2 Jul 4, 2017

Member

nit : remote whitespaces.

@harshjain2

harshjain2 Jul 4, 2017

Member

nit : remote whitespaces.

This comment has been minimized.

@Shyam-Gupta

Shyam-Gupta Jul 5, 2017

Member

Its required for indentation.

@Shyam-Gupta

Shyam-Gupta Jul 5, 2017

Member

Its required for indentation.

Show outdated Hide outdated src/vstest.console/TestPlatformHelpers/TestRequestManager.cs
}

This comment has been minimized.

@harshjain2

harshjain2 Jul 4, 2017

Member

nit : remote whitespaces

@harshjain2

harshjain2 Jul 4, 2017

Member

nit : remote whitespaces

This comment has been minimized.

@Shyam-Gupta

Shyam-Gupta Jul 5, 2017

Member

Done

@Shyam-Gupta
@harshjain2

This comment has been minimized.

Show comment
Hide comment
@harshjain2

harshjain2 Jul 4, 2017

Member

@dotnet-bot test this please.

Member

harshjain2 commented Jul 4, 2017

@dotnet-bot test this please.

Shyam Gupta and others added some commits Jul 5, 2017

Shyam Gupta
Shyam Gupta

@Shyam-Gupta Shyam-Gupta merged commit 8ca269f into Microsoft:master Jul 6, 2017

4 checks passed

Ubuntu16.04 / Debug Build Build finished.
Details
Ubuntu16.04 / Release Build Build finished.
Details
Windows_NT / Debug Build Build finished.
Details
Windows_NT / Release Build Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment