New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CancellationToken to Testhost launch async #917

Merged
merged 9 commits into from Jul 11, 2017

Conversation

Projects
None yet
5 participants
@mayankbansal018
Contributor

mayankbansal018 commented Jul 6, 2017

No description provided.

@mayankbansal018 mayankbansal018 self-assigned this Jul 6, 2017

@mayankbansal018 mayankbansal018 requested a review from codito Jul 6, 2017

@@ -105,7 +109,7 @@ public virtual int StartTestRun(TestRunCriteria testRunCriteria, ITestRunEventsH
this.InitializeExtensions(testSources);
}
this.SetupChannel(testRunCriteria.Sources);
this.SetupChannel(testRunCriteria.Sources, this.cancellationTokenSource.Token);

This comment has been minimized.

@codito

codito Jul 10, 2017

Contributor

Should we consider defining this CancellationTokenSource in ProxyOperationManager?

@codito

codito Jul 10, 2017

Contributor

Should we consider defining this CancellationTokenSource in ProxyOperationManager?

This comment has been minimized.

@mayankbansal018

mayankbansal018 Jul 11, 2017

Contributor

next PR

@mayankbansal018

mayankbansal018 Jul 11, 2017

Contributor

next PR

Show outdated Hide outdated src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs
Show outdated Hide outdated src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs
Show outdated Hide outdated src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs
Show outdated Hide outdated src/Microsoft.TestPlatform.ObjectModel/Host/ITestRunTimeProvider.cs
Show outdated Hide outdated src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs
Show outdated Hide outdated src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs
Show outdated Hide outdated src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs
Show outdated Hide outdated src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs
Show outdated Hide outdated src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs
Show outdated Hide outdated src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs
Show outdated Hide outdated src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs
Show outdated Hide outdated src/Microsoft.TestPlatform.ObjectModel/Host/ITestRunTimeProvider.cs
Show outdated Hide outdated ...icrosoft.TestPlatform.TestHostProvider/Hosting/DefaultTestHostManager.cs
{
try
{
this.processHelper.TerminateProcess(processId);
this.processHelper.TerminateProcess(this.testHostProcess.Id);

This comment has been minimized.

@codito

codito Jul 11, 2017

Contributor

Can testHostProcess be null?

@codito

codito Jul 11, 2017

Contributor

Can testHostProcess be null?

mayankbansal018 added some commits Jul 11, 2017

@codito

codito approved these changes Jul 11, 2017

Show outdated Hide outdated src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyOperationManager.cs
Show outdated Hide outdated src/Microsoft.TestPlatform.ObjectModel/Host/ITestRunTimeProvider.cs
Show outdated Hide outdated ...tPlatform.CrossPlatEngine.UnitTests/Client/ProxyExecutionManagerTests.cs
Show outdated Hide outdated ...atform.TestHostProvider.UnitTests/Hosting/DefaultTestHostManagerTests.cs
Show outdated Hide outdated ...atform.TestHostProvider.UnitTests/Hosting/DefaultTestHostManagerTests.cs
Show outdated Hide outdated ...latform.TestHostProvider.UnitTests/Hosting/DotnetTestHostManagerTests.cs
this.testOperationManager.Close();
this.mockRequestSender.Verify(rs => rs.EndSession(), Times.Once);
}
[TestMethod]
public void CloseShouldNotEndSessionIfHostLaucnhedFailed()

This comment has been minimized.

@codito

codito Jul 11, 2017

Contributor

nit: spell Launched

@codito

codito Jul 11, 2017

Contributor

nit: spell Launched

This comment has been minimized.

@mayankbansal018

mayankbansal018 Jul 11, 2017

Contributor

resolved

@mayankbansal018

mayankbansal018 Jul 11, 2017

Contributor

resolved

Show outdated Hide outdated ...tPlatform.CrossPlatEngine.UnitTests/Client/ProxyOperationManagerTests.cs

@mayankbansal018 mayankbansal018 merged commit dec379d into Microsoft:master Jul 11, 2017

4 checks passed

Ubuntu16.04 / Debug Build Build finished.
Details
Ubuntu16.04 / Release Build Build finished.
Details
Windows_NT / Debug Build Build finished.
Details
Windows_NT / Release Build Build finished.
Details

@mayankbansal018 mayankbansal018 deleted the mayankbansal018:runtime-launchhostcancellable branch Jul 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment