New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vswhere for building vsix #923

Merged
merged 3 commits into from Jul 12, 2017

Conversation

Projects
None yet
4 participants
@codito
Contributor

codito commented Jul 11, 2017

Remove dependency on locate-vs package. Allow lookup for prerelease VS
when building dev packages.

Upgrade to latest Moq, this fixes an issue with TypeConverter dependency.
Upgrade to latest MSTest beta package.

Use vswhere for building vsix.
Remove dependency on locate-vs package. Allow lookup for prerelease VS
when building dev packages.

Upgrade to latest Moq, this fixes an issue with TypeConverter dependency.
Upgrade to latest MSTest beta package.
Show outdated Hide outdated scripts/build.ps1
$requiredPackageIds = @("Microsoft.Component.MSBuild", "Microsoft.Net.Component.4.6.TargetingPack", "Microsoft.VisualStudio.Component.Roslyn.Compiler", "Microsoft.VisualStudio.Component.VSSDK")

This comment has been minimized.

@jayaranigarg

jayaranigarg Jul 11, 2017

Member

Is Roslyn compiler required?

@jayaranigarg

jayaranigarg Jul 11, 2017

Member

Is Roslyn compiler required?

This comment has been minimized.

@codito

codito Jul 11, 2017

Contributor

It is not required, it seems to be a dependency of MSBuild component already. Will remove it before merge.

@codito

codito Jul 11, 2017

Contributor

It is not required, it seems to be a dependency of MSBuild component already. Will remove it before merge.

codito added some commits Jul 12, 2017

Remove dependency on Roslyn.Compiler package
MSBuild already depends on the compiler.

@codito codito merged commit b6c39d5 into Microsoft:master Jul 12, 2017

4 checks passed

Ubuntu16.04 / Debug Build Build finished.
Details
Ubuntu16.04 / Release Build Build finished.
Details
Windows_NT / Debug Build Build finished.
Details
Windows_NT / Release Build Build finished.
Details

@codito codito deleted the codito:moq-update branch Jul 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment