New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building for NS1.4 #945

Merged
merged 7 commits into from Jul 21, 2017

Conversation

Projects
None yet
5 participants
@mayankbansal018
Contributor

mayankbansal018 commented Jul 19, 2017

No description provided.

Show outdated Hide outdated src/Microsoft.TestPlatform.Client/DesignMode/DesignModeClient.cs
Show outdated Hide outdated src/Microsoft.TestPlatform.Client/DesignMode/DesignModeClient.cs
Show outdated Hide outdated ...osoft.TestPlatform.CrossPlatEngine/DataCollection/InProcDataCollector.cs
Show outdated Hide outdated ...osoft.TestPlatform.CrossPlatEngine/DataCollection/InProcDataCollector.cs
Show outdated Hide outdated ...osoft.TestPlatform.CrossPlatEngine/DataCollection/InProcDataCollector.cs
Show outdated Hide outdated ...atform.PlatformAbstractions/uap10.0/Runtime/PlatformAssemblyExtension.cs
#else
assembly = AssemblyLoadContext.Default.LoadFromAssemblyPath(assemblyPath);
#endif
Assembly assembly = new PlatformAssemblyLoadContext().LoadAssemblyFromPath(assemblyPath);

This comment has been minimized.

@codito

codito Jul 21, 2017

Contributor

Make it testable and add unit tests please.

@codito

codito Jul 21, 2017

Contributor

Make it testable and add unit tests please.

Environment.Exit(1);
});
// In remote scenario we cannot monitor parent process, so we expect user to pass parentProcessId as -1

This comment has been minimized.

@codito

codito Jul 21, 2017

Contributor

In that case, is it the runtime providers responsibility to clean up the stale test host processes? Should it be called out explicitly somewhere?

@codito

codito Jul 21, 2017

Contributor

In that case, is it the runtime providers responsibility to clean up the stale test host processes? Should it be called out explicitly somewhere?

This comment has been minimized.

@mayankbansal018

mayankbansal018 Jul 21, 2017

Contributor

The responsibility to clean up test runner lies with it's RuntimeProvider, but if vstest.console is dead then runtime provider won't get a chance to clean up, the best we can achieve here is safely exit the UWP app.

@mayankbansal018

mayankbansal018 Jul 21, 2017

Contributor

The responsibility to clean up test runner lies with it's RuntimeProvider, but if vstest.console is dead then runtime provider won't get a chance to clean up, the best we can achieve here is safely exit the UWP app.

Show outdated Hide outdated src/testhost.x86/Program.cs
Show outdated Hide outdated src/testhost/testhost.csproj
@mayankbansal018

This comment has been minimized.

Show comment
Hide comment
@mayankbansal018

mayankbansal018 Jul 21, 2017

Contributor

@dotnet-bot Test this please

Contributor

mayankbansal018 commented Jul 21, 2017

@dotnet-bot Test this please

@mayankbansal018 mayankbansal018 merged commit ea6d158 into Microsoft:master Jul 21, 2017

4 checks passed

Ubuntu16.04 / Debug Build Build finished.
Details
Ubuntu16.04 / Release Build Build finished.
Details
Windows_NT / Debug Build Build finished.
Details
Windows_NT / Release Build Build finished.
Details

@mayankbansal018 mayankbansal018 deleted the mayankbansal018:assembly-abstraction2 branch Jul 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment