New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize Microsoft.TestPlatform.build.dll #952

Merged
merged 12 commits into from Jul 27, 2017

Conversation

Projects
None yet
3 participants
@Faizan2304
Contributor

Faizan2304 commented Jul 24, 2017

Issue: #861

@Faizan2304 Faizan2304 requested review from codito and harshjain2 Jul 24, 2017

@@ -10,11 +10,27 @@
<WarningsAsErrors>true</WarningsAsErrors>
</PropertyGroup>
<ItemGroup>
<EmbeddedResource Include="Resources\Resources.resx" />

This comment has been minimized.

@codito

codito Jul 25, 2017

Contributor

How are the resources packaged?

@codito

codito Jul 25, 2017

Contributor

How are the resources packaged?

This comment has been minimized.

@Faizan2304

Faizan2304 Jul 25, 2017

Contributor

Thanks @codito for catching this. Fixed in next commit.

@Faizan2304

Faizan2304 Jul 25, 2017

Contributor

Thanks @codito for catching this. Fixed in next commit.

@Faizan2304

This comment has been minimized.

Show comment
Hide comment
@Faizan2304

Faizan2304 Jul 25, 2017

Contributor

@dotnet-bot test Ubuntu16.04 / Release Build please
@dotnet-bot test Ubuntu16.04 / Debug Build please

Contributor

Faizan2304 commented Jul 25, 2017

@dotnet-bot test Ubuntu16.04 / Release Build please
@dotnet-bot test Ubuntu16.04 / Debug Build please

@codito

codito approved these changes Jul 25, 2017

@Faizan2304

This comment has been minimized.

Show comment
Hide comment
@Faizan2304

Faizan2304 Jul 25, 2017

Contributor

@dotnet-bot test Ubuntu16.04 / Release Build please
@dotnet-bot test Ubuntu16.04 / Debug Build please

Contributor

Faizan2304 commented Jul 25, 2017

@dotnet-bot test Ubuntu16.04 / Release Build please
@dotnet-bot test Ubuntu16.04 / Debug Build please

@Faizan2304 Faizan2304 merged commit fd51793 into Microsoft:master Jul 27, 2017

4 checks passed

Ubuntu16.04 / Debug Build Build finished.
Details
Ubuntu16.04 / Release Build Build finished.
Details
Windows_NT / Debug Build Build finished.
Details
Windows_NT / Release Build Build finished.
Details

@Faizan2304 Faizan2304 deleted the Faizan2304:issue861 branch Jul 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment