New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed loading of Discoverers while executing tests. #955

Merged
merged 4 commits into from Jul 26, 2017

Conversation

Projects
None yet
4 participants
@harshjain2
Member

harshjain2 commented Jul 25, 2017

Removed loading of Discoverers while executing tests.
This is bound to give perf benefit of ~100 milliseconds.

@harshjain2 harshjain2 requested a review from codito Jul 25, 2017

@codito

codito approved these changes Jul 26, 2017

@@ -171,10 +171,6 @@ private void LoadExtensions()
// Load the extensions on creation so that we dont have to spend time during first execution.
EqtTrace.Verbose("TestExecutorService: Loading the extensions");
TestDiscoveryExtensionManager.LoadAndInitializeAllExtensions(false);

This comment has been minimized.

@codito

codito Jul 26, 2017

Contributor

No tests are impacted?

@codito

codito Jul 26, 2017

Contributor

No tests are impacted?

This comment has been minimized.

@harshjain2

harshjain2 Jul 26, 2017

Member

Fixed

@harshjain2

@harshjain2 harshjain2 merged commit 2c3a9f5 into Microsoft:master Jul 26, 2017

4 checks passed

Ubuntu16.04 / Debug Build Build finished.
Details
Ubuntu16.04 / Release Build Build finished.
Details
Windows_NT / Debug Build Build finished.
Details
Windows_NT / Release Build Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment