Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed loading of Discoverers while executing tests. #955

Merged
merged 4 commits into from Jul 26, 2017

Conversation

harshjain2
Copy link
Contributor

@harshjain2 harshjain2 commented Jul 25, 2017

Removed loading of Discoverers while executing tests.
This is bound to give perf benefit of ~100 milliseconds.

@harshjain2 harshjain2 requested a review from codito July 25, 2017 13:46
@@ -171,10 +171,6 @@ private void LoadExtensions()
// Load the extensions on creation so that we dont have to spend time during first execution.
EqtTrace.Verbose("TestExecutorService: Loading the extensions");

TestDiscoveryExtensionManager.LoadAndInitializeAllExtensions(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests are impacted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@harshjain2 harshjain2 merged commit 2c3a9f5 into microsoft:master Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants