Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce windows crate size by reducing the amount of Xaml bindings #1341

Merged
merged 1 commit into from Nov 19, 2021

Conversation

kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Nov 19, 2021

The Xaml API is huge and has a deep class hierarchy that ends up causing an explosion of redundant method definitions as the class hierarchy is simulated in Rust. This update avoids stamping out those "inherited" methods for derived classes. Callers can still cast to base classes to call them, but this dramatically reduces the code size and should even improve compile time for developers using Xaml. There is a bit of a usability hit if you happen to be using Xaml, but since it is focused on C# developers I don't think that's a serious concern.

@kennykerr kennykerr merged commit 83d0908 into master Nov 19, 2021
14 checks passed
@kennykerr kennykerr deleted the less-xaml branch Nov 19, 2021
@kennykerr kennykerr mentioned this pull request Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant