Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test component re-build reliability #2303

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Fix test component re-build reliability #2303

merged 1 commit into from
Jan 25, 2023

Conversation

kennykerr
Copy link
Collaborator

The build script wasn't reliably detecting when the MIDL compiler failed, leading cargo to cache the last successful result and seemingly ignoring IDL changes.

@kennykerr kennykerr requested a review from riverar January 24, 2023 20:11
Copy link
Collaborator

@riverar riverar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see midlrt errors in stdout/err now too.

@kennykerr kennykerr merged commit 15cefaf into master Jan 25, 2023
@kennykerr kennykerr deleted the build-rerun branch January 25, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants