Skip to content

Added IntelliJ IDEA Community Edition#179

Closed
denelon wants to merge 2 commits intomicrosoft:masterfrom
denelon:denelon-intellijC
Closed

Added IntelliJ IDEA Community Edition#179
denelon wants to merge 2 commits intomicrosoft:masterfrom
denelon:denelon-intellijC

Conversation

@denelon
Copy link
Copy Markdown
Collaborator

@denelon denelon commented May 16, 2020

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 16, 2020
@ghost
Copy link
Copy Markdown

ghost commented May 16, 2020

denelon The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the YAML file is compliant with the package manager specification (https://github.com/microsoft/winget-pkgs/YAMLSpec.md)
For details on the error, see the details link below in the build pipeline.

@wingetbot
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 17, 2020
@ghost ghost assigned KevinLaMS May 17, 2020
@ghost
Copy link
Copy Markdown

ghost commented May 17, 2020

This submission has moved to manual review.

@KevinLaMS
Copy link
Copy Markdown
Contributor

Installer is looking for a response file.
This is issue: microsoft/winget-cli#158

@KevinLaMS KevinLaMS added the Blocking-Issue Manifest validation is blocked by a known issue. label May 18, 2020
@denelon denelon linked an issue May 18, 2020 that may be closed by this pull request
@mimi89999
Copy link
Copy Markdown
Contributor

mimi89999 commented May 20, 2020

In the case of Jetbrains installers only mode=admin is required. I tried to convince them to make it default (currently they have no default for this), but they didn't understand the issue: https://youtrack.jetbrains.com/issue/IDEA-226645

Maybe the community could convinve them to have sane defaults and not require a config file for a very common install config.

@lokinmodar
Copy link
Copy Markdown

In the case of Jetbrains installers only mode=admin is required. I tried to convince them to make it default (currently they have no default for this), but they didn't understand the issue: https://youtrack.jetbrains.com/issue/IDEA-226645

Maybe the community could convinve them to have sane defaults and not require a config file for a very common install config.

This is an issue for all their installers. They refuse to acknowledge the problem.

@mimi89999
Copy link
Copy Markdown
Contributor

Two other issues have been opened (https://youtrack.jetbrains.com/issue/IDEA-242025, https://youtrack.jetbrains.com/issue/TBX-4949), but there still isn't any real feedback from them. I think that the problem here is that they don't quite understand what they have to do.

@KevinLaMS KevinLaMS removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jul 18, 2020
@KevinLaMS
Copy link
Copy Markdown
Contributor

as mentioned above this is blocked.
image

@mimi89999
Copy link
Copy Markdown
Contributor

I opened the PR with the required changes to IntelliJ two months ago, but is still hasn't been accepted. The dev that is following this PR asked about winger popularity in JetBrains/intellij-community#1400 (comment). Maybe the community and users who would like to see JetBrains products in WinGet could speak up in that pull request?

@denelon
Copy link
Copy Markdown
Collaborator Author

denelon commented Nov 16, 2020

It looks like the PR at JetBrains is closed JetBrains/intellij-community#1400 (comment) but there was a comment from @trespasserw indicating the change is in the main branch. The manifest here would need to be updated to the current supported version.

@denelon
Copy link
Copy Markdown
Collaborator Author

denelon commented Nov 16, 2020

@mimi89999 feel free to submit a new PR and I'll close this one, or let me know what changes need to be made.

@mimi89999
Copy link
Copy Markdown
Contributor

@denelon I will submit a PR when the new version with that change will be released. Now we basically only need to wait for the release and it should work as any other NSIS installer, so it will be easy to add.

@mimi89999
Copy link
Copy Markdown
Contributor

@denelon Just opened #5212

@mimi89999
Copy link
Copy Markdown
Contributor

Also opened #5213 for PyCharm

@denelon
Copy link
Copy Markdown
Collaborator Author

denelon commented Mar 31, 2021

JetBrains.IntelliJIDEA.Community was added in another PR.

@denelon denelon closed this Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocking-Issue Manifest validation is blocked by a known issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Config files to support silent installation

5 participants