Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackageIdentifier: CircuitDiagram.CircuitDiagram version 3.0 #22801

Merged
2 commits merged into from Jul 30, 2021

Conversation

vedantmgoyal9
Copy link
Contributor

@vedantmgoyal9 vedantmgoyal9 commented Jul 30, 2021

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jul 30, 2021
@ghost
Copy link

ghost commented Jul 30, 2021

Hello @vedantmgoyal2009,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jul 30, 2021
Copy link
Contributor

@ImJoakim ImJoakim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to change the file name to match the new PackageIdentifier.

Manifest: The filename must match the PackageIdentifier and ManifestType properties from the manifest. actual 'circuitdiagram.circuitdiagram.yaml', expected 'CircuitDiagram.CircuitDiagram.yaml'

@ghost ghost removed Needs: author feedback Needs-Author-Feedback This needs a response from the author. Manifest-Validation-Error Manifest validation failed labels Jul 30, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jul 30, 2021
@ghost
Copy link

ghost commented Jul 30, 2021

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Jul 30, 2021
Copy link
Contributor

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 30, 2021
@ghost
Copy link

ghost commented Jul 30, 2021

Hello @vedantmgoyal2009,
Validation has completed.

@ghost ghost merged commit 55be45c into microsoft:master Jul 30, 2021
@vedantmgoyal9 vedantmgoyal9 deleted the CircuitDiagram.CircuitDiagram-3.0 branch July 30, 2021 09:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants