Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Pad 5.2.0 #5508

Closed
wants to merge 4 commits into from
Closed

Quick Pad 5.2.0 #5508

wants to merge 4 commits into from

Conversation

yaira2
Copy link
Contributor

@yaira2 yaira2 commented Dec 14, 2020

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Dec 14, 2020
@ghost ghost assigned denelon Dec 14, 2020
@ghost
Copy link

ghost commented Dec 14, 2020

This submission has moved to manual review.

@KevinLaMS KevinLaMS added the Validation-MSIX-Dependency This label indicates that the MSIX has a dependency that is not filled. label Dec 15, 2020
@KevinLaMS
Copy link
Contributor

KevinLaMS commented Dec 15, 2020

Clean up image

@ghost ghost assigned yaira2 Dec 15, 2020
@ghost ghost added Needs: author feedback Blocking-Issue Manifest validation is blocked by a known issue. and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Dec 15, 2020
@ghost
Copy link

ghost commented Dec 15, 2020

Greetings. This package fails because it is dependent on some frameworks, and we do not support the dependencies yet. See issue: microsoft/winget-cli#163
In the meantime, if you include the dependencies in your package, it should pass.

@yaira2
Copy link
Contributor Author

yaira2 commented Dec 15, 2020

@KevinLaMS Being that WinGet will support installing apps from the store, I don't think it's worth investing so much for this package right now. Is there a process to remove an app from WinGet or do I just need to delete the folder for it?

@KevinLaMS
Copy link
Contributor

I think what we should do is keep this PR active as active so that once dependencies are done, we can add this if we want.
I agree, the 404 error we get with the current package is not good. It would be great if you want to put through the RM for that package.

@yaira2
Copy link
Contributor Author

yaira2 commented Dec 20, 2020

I think what we should do is keep this PR active as active so that once dependencies are done, we can add this if we want.
I agree, the 404 error we get with the current package is not good. It would be great if you want to put through the RM for that package.

I removed the outdated package for Quick Pad over here #5627.

@vedantmgoyal9
Copy link
Contributor

@denelon @KevinLaMS This PR can be closed as the version of the manifest being used is 0.1.0.

@yaira2
Copy link
Contributor Author

yaira2 commented Sep 10, 2021

@denelon @KevinLaMS This PR can be closed as the version of the manifest being used is 0.1.0.

How can that be resolved?

@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Sep 10, 2021
Co-authored-by: Vedant Mohan Goyal <83997633+vedantmgoyal2009@users.noreply.github.com>
@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed No-Recent-Activity No activity has occurred on this work item for seven days. labels Sep 17, 2021
@yaira2 yaira2 marked this pull request as draft September 17, 2021 21:18
@ghost ghost removed Manifest-Validation-Error Manifest validation failed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Sep 17, 2021
@yaira2 yaira2 marked this pull request as ready for review September 17, 2021 21:19
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Sep 17, 2021
@ghost
Copy link

ghost commented Sep 17, 2021

Hello @yaichenbaum,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Sep 17, 2021
@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Sep 25, 2021
@ghost
Copy link

ghost commented Sep 25, 2021

Hello @yaichenbaum,
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@yaira2
Copy link
Contributor Author

yaira2 commented Sep 26, 2021

@vedantmgoyal2009 I'm not sure why this isn't working, any ideas?

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. No-Recent-Activity No activity has occurred on this work item for seven days. labels Sep 26, 2021
@quhxl
Copy link
Contributor

quhxl commented Sep 26, 2021

The folder should be manifests\q\QuickPad\QuickPad\5.2.0 and not manifests\QuickPad\QuickPad\5.2.0

…nifests/q/QuickPad/QuickPad/5.2.0/QuickPad.QuickPad.yaml
@ghost ghost removed Manifest-Validation-Error Manifest validation failed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Sep 26, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Sep 26, 2021
@ghost ghost assigned ChuckFerring-zz Sep 26, 2021
@arjun-msft
Copy link
Member

@yaichenbaum this appears to be a paid app, after I install it and run it, it is blocked and takes me to the store. We are unable to install paid apps at the moment, I believe we are blocked on this: microsoft/winget-cli#908.

@arjun-msft arjun-msft added the Blocking-Issue Manifest validation is blocked by a known issue. label Sep 29, 2021
@yaira2 yaira2 closed this Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Executable-Error Validation-MSIX-Dependency This label indicates that the MSIX has a dependency that is not filled.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants