Fix integration tests.#773
Merged
Merged
Conversation
DingmaomaoBJTU
left a comment
DingmaomaoBJTU
left a comment
Collaborator
There was a problem hiding this comment.
Overall: Straightforward fix — materializing the generator into a list and updating golden files. LGTM with minor suggestions.
Collaborator
|
Minor: The PR body is empty. It would help reviewers (and future git-log readers) to include a one-liner explaining what broke — e.g., 'check_on_ep now yields results lazily; the golden files were regenerated on the latest hardware.' Also consider linking the upstream change that introduced the generator return type. |
vortex-captain
approved these changes
Jun 2, 2026
DingmaomaoBJTU
pushed a commit
that referenced
this pull request
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.