Replaced visible <i> with a markdown code syntax
#46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't understand the doc at first, because the \ was missing and the <i> was visible. This change clarifies the syntax. If you prefer to keep the italics semantic instead, I'm fine with that too, but fix that properly.
|
@jeremyVignelles : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Contributor
|
you could've simply escaped the backslashes by inserting another backslash, which in turn would make the italics work |
Contributor
Author
|
Feel free to open another PR and close this one then. I don't have any strong feeling on that matter. |
Utilizing markdown syntax.
Contributor
|
Thanks for your contribution, I've merged your changes and they should be live soon. |
|
@lastnameholiu : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
xiaoyinl
added a commit
to xiaoyinl/sdk-api
that referenced
this pull request
Feb 10, 2020
See MicrosoftDocs#46. I think the convention is to only italicize variable names. The `ServiceName` should be changed to the actual name of the service, but `NT SERVICE` should not, so it seems we'd better not italicize `NT SERVICE`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't understand the doc at first, because the \ was missing and the
<i>was visible. This change clarifies the syntax.If you prefer to keep the italics semantic instead, I'm fine with that too, but fix that properly.