-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update nf-d3d10shader-id3d10shaderreflectiontype-getmembertypename.md #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed document descritption and return value
|
@spoiltos : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
stevewhims
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a mail out to the feature team to double-check that the descriptions here are accurate, so please stand by. The "(function name contains a typo, should be GetMemberName)" part looks like product feedback, so we can't merge that into the content. Once I have all the info, I'll make a new commit to this PR and then approve and merge it. Thanks!
stevewhims
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With input from the feature team, I did an edit pass on the PR.
|
Hi, @spoiltos, I'm ready to merge and complete this PR, it's just currently blocked on your signing the license/cla. Please see the check item in the UI below. Thanks! |
|
@stevewhims : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Hi @stevewhims, I've signed the license/cla. Also I like your new changes, thanks a lot! |
|
Thank you, @spoiltos! :) |
Fixed document descritption and return value