From f07578a0614e7c9257ee863b5f8f140a5f47a745 Mon Sep 17 00:00:00 2001 From: Vincent Biret Date: Tue, 17 Aug 2021 07:58:34 -0400 Subject: [PATCH 1/5] - fixes stages names for pipeline --- .azure-pipelines/buildAndPackage.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.azure-pipelines/buildAndPackage.yml b/.azure-pipelines/buildAndPackage.yml index c44f1069b..00ca295f0 100644 --- a/.azure-pipelines/buildAndPackage.yml +++ b/.azure-pipelines/buildAndPackage.yml @@ -46,10 +46,10 @@ stages: - template: templates/build/publish-artefacts.yml - template: templates/alert-failure.yml -- stage: Maven-Preview +- stage: Maven_Preview condition: and(succeeded(), eq(variables['Build.SourceBranch'], 'refs/heads/dev')) jobs: - - deployment: Maven-Preview + - deployment: Maven_Preview environment: 'MSGraph SDK Development - Java' pool: vmImage: windows-latest @@ -63,11 +63,11 @@ stages: task: 'publishSnapshotPublicationToSonatypeSnapshotRepository' - template: templates/alert-failure.yml -- stage: Maven-Release-And-Github-Release +- stage: Maven_Release_And_Github_Release dependsOn: [] condition: and(succeeded(), eq(variables['Build.SourceBranch'], 'refs/heads/master')) jobs: - - deployment: Maven-Release + - deployment: Maven_Release environment: 'MSGraph SDK Development - Java' pool: vmImage: windows-latest @@ -83,8 +83,8 @@ stages: task: 'publishMavenCentralReleasePublicationToSonatypeRepository' - template: templates/alert-failure.yml - - deployment: Github-Release - dependsOn: Maven-Release + - deployment: Github_Release + dependsOn: Maven_Release environment: 'MSGraph SDK Development - Java' pool: vmImage: windows-latest From 1f1d5b720ba51ea8dea3743e9afe2bef06923751 Mon Sep 17 00:00:00 2001 From: Vincent Biret Date: Tue, 17 Aug 2021 08:07:00 -0400 Subject: [PATCH 2/5] - switches github connection to production connection --- .azure-pipelines/buildAndPackage.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.azure-pipelines/buildAndPackage.yml b/.azure-pipelines/buildAndPackage.yml index 00ca295f0..1cb9e9354 100644 --- a/.azure-pipelines/buildAndPackage.yml +++ b/.azure-pipelines/buildAndPackage.yml @@ -94,5 +94,5 @@ stages: steps: - template: templates/version-and-release.yml parameters: - gitConnection: 'ramsessanchez' + gitConnection: 'microsoftgraph' - template: templates/alert-failure.yml From 0d219e3bea0db3e2de0dab628ea9e1056587193f Mon Sep 17 00:00:00 2001 From: Vincent Biret Date: Tue, 17 Aug 2021 08:32:15 -0400 Subject: [PATCH 3/5] - removes alert failure as this is natively supported in teams now --- .azure-pipelines/buildAndPackage.yml | 4 ---- .azure-pipelines/templates/alert-failure.yml | 10 ---------- 2 files changed, 14 deletions(-) delete mode 100644 .azure-pipelines/templates/alert-failure.yml diff --git a/.azure-pipelines/buildAndPackage.yml b/.azure-pipelines/buildAndPackage.yml index 1cb9e9354..3450a2f18 100644 --- a/.azure-pipelines/buildAndPackage.yml +++ b/.azure-pipelines/buildAndPackage.yml @@ -44,7 +44,6 @@ stages: stageID: 'build' - template: templates/build/build-and-coverage.yml - template: templates/build/publish-artefacts.yml - - template: templates/alert-failure.yml - stage: Maven_Preview condition: and(succeeded(), eq(variables['Build.SourceBranch'], 'refs/heads/dev')) @@ -61,7 +60,6 @@ stages: - template: templates/copy-and-build.yml parameters: task: 'publishSnapshotPublicationToSonatypeSnapshotRepository' - - template: templates/alert-failure.yml - stage: Maven_Release_And_Github_Release dependsOn: [] @@ -81,7 +79,6 @@ stages: - template: templates/copy-and-build.yml parameters: task: 'publishMavenCentralReleasePublicationToSonatypeRepository' - - template: templates/alert-failure.yml - deployment: Github_Release dependsOn: Maven_Release @@ -95,4 +92,3 @@ stages: - template: templates/version-and-release.yml parameters: gitConnection: 'microsoftgraph' - - template: templates/alert-failure.yml diff --git a/.azure-pipelines/templates/alert-failure.yml b/.azure-pipelines/templates/alert-failure.yml deleted file mode 100644 index 51f2043d0..000000000 --- a/.azure-pipelines/templates/alert-failure.yml +++ /dev/null @@ -1,10 +0,0 @@ -steps: -- task: YodLabs.O365PostMessage.O365PostMessageBuild.O365PostMessageBuild@0 - displayName: 'Graph Client Tooling pipeline fail notification' - inputs: - addressType: serviceEndpoint - serviceEndpointName: 'microsoftgraph pipeline status' - title: '$(Build.DefinitionName) failure notification' - text: 'This pipeline has failed. View the build details for further information. This is a blocking failure. ' - condition: and(failed(), ne(variables['Build.Reason'], 'Manual')) - enabled: true \ No newline at end of file From c82f929d1f9e93438435686d6465748738c0365e Mon Sep 17 00:00:00 2001 From: Vincent Biret Date: Tue, 17 Aug 2021 08:46:45 -0400 Subject: [PATCH 4/5] - updates connection name to organisation --- .azure-pipelines/buildAndPackage.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.azure-pipelines/buildAndPackage.yml b/.azure-pipelines/buildAndPackage.yml index 3450a2f18..24df97fc7 100644 --- a/.azure-pipelines/buildAndPackage.yml +++ b/.azure-pipelines/buildAndPackage.yml @@ -91,4 +91,4 @@ stages: steps: - template: templates/version-and-release.yml parameters: - gitConnection: 'microsoftgraph' + gitConnection: 'microsoftgraphrelease' From 0b7cf21d06e7995e1d8ee6645773da0e9f2c8394 Mon Sep 17 00:00:00 2001 From: Vincent Biret Date: Tue, 17 Aug 2021 08:56:43 -0400 Subject: [PATCH 5/5] - upgrades credscan tool to suppress warning --- .azure-pipelines/templates/build/checkout-and-credscan.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.azure-pipelines/templates/build/checkout-and-credscan.yml b/.azure-pipelines/templates/build/checkout-and-credscan.yml index cc5c7c2f5..a04eb92eb 100644 --- a/.azure-pipelines/templates/build/checkout-and-credscan.yml +++ b/.azure-pipelines/templates/build/checkout-and-credscan.yml @@ -6,4 +6,5 @@ steps: - task: securedevelopmentteam.vss-secure-development-tools.build-task-credscan.CredScan@2 displayName: 'Run CredScan' inputs: - debugMode: false \ No newline at end of file + debugMode: false + toolMajorVersion: V2 \ No newline at end of file