Skip to content

Conversation

@ramsessanchez
Copy link
Contributor

V6 upgrade guide

@ramsessanchez ramsessanchez requested a review from a team as a code owner January 20, 2024 01:37
Copy link
Contributor

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great really @ramsessanchez

  • Should the PR be targeting the dev or the kiota branch
  • Any chance we can also add a section in Readme.md linking to this file in the event one reads they can discover this as well?

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work! I love the fact that it showcases more capabilities with less code in general!
@maisarissi can you schedule a slot on the pnp call post GA so Ramses and you can demonstrate all that goodness and amplify the roll out?

@ramsessanchez
Copy link
Contributor Author

ramsessanchez commented Jan 22, 2024

  • Should the PR be targeting the dev or the kiota branch

@andrueastman I wasn't sure here. My thinking was that once we GA this branch will hold all the 6.0 stuff so putting this here would be okay since it doesn't affect functionality.

@andrueastman
Copy link
Contributor

My thinking was that once we GA this branch will hold all the 6.0 stuff so putting this here would be okay since it doesn't affect functionality.

That's valid. In my head, the reasoning is also similar in that the kiota branch will go into the branch eventually so I thought it may make sense to have the guide initially live with the 6.0 stuff and they go in together.

@ramsessanchez ramsessanchez merged commit 16e2fcc into dev Jan 23, 2024
@ramsessanchez ramsessanchez deleted the v6-upgrade-guide branch January 23, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants