Skip to content

Conversation

@muthurathinam
Copy link
Contributor

Summary

Updated MSALProvider's constructor to accept UserAgentApplication

Motivation

Accepting UserAgentApplication reduces the implementing interfaces for functionalities of userAgentApplication inside provider.

Test plan

  • Initialize the UserAgentApplication and Pass in the instance while initializing the MSALAuthenticationProvider.
  • Browser Sample also updated with same as above so running the browser sample will also ensure its validation.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

@NakulSabharwal NakulSabharwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@muthurathinam muthurathinam merged commit c50be7f into dev Apr 4, 2019
@muthurathinam muthurathinam deleted the MSALProvider_UserAgentApp branch April 4, 2019 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants