From 8a595c01c1a342952b2b75c9f22e981fe0e02104 Mon Sep 17 00:00:00 2001 From: Sahil Date: Mon, 27 Sep 2021 11:47:09 +0530 Subject: [PATCH] fix(samples): added secrets file and updated documentation --- .gitignore | 1 - .../tokenCredentialAuthenticationProvider/README.md | 6 ++++-- .../tokenCredentialAuthenticationProvider/index.js | 4 ---- .../tokenCredentialAuthenticationProvider/secrets.js | 11 +++++++++++ 4 files changed, 15 insertions(+), 7 deletions(-) create mode 100644 samples/javascript/clientInitialization/tokenCredentialAuthenticationProvider/secrets.js diff --git a/.gitignore b/.gitignore index 88961f9eb..077d0e37f 100644 --- a/.gitignore +++ b/.gitignore @@ -21,7 +21,6 @@ src/**/*.js.map src/**/*.d.ts samples/**/secrets.ts -samples/**/secrets.js samples/node_modules/** samples/lib/ diff --git a/samples/javascript/clientInitialization/tokenCredentialAuthenticationProvider/README.md b/samples/javascript/clientInitialization/tokenCredentialAuthenticationProvider/README.md index 2c65cd347..cfb806355 100644 --- a/samples/javascript/clientInitialization/tokenCredentialAuthenticationProvider/README.md +++ b/samples/javascript/clientInitialization/tokenCredentialAuthenticationProvider/README.md @@ -18,6 +18,8 @@ 4. Navigate to the samples folder [./samples]and run `npm install` -5. Navigate to tokenCredentialAuthenticationProvider[./samples/javascript/clientInitialization/tokenCredentialAuthenticationProvider] in the samples directory. +5. Navigate to secrets.js[./secrets] and populate all the values (tenantId, clientId, clientSecret, scopes) -6. For running this javascript sample, run `node index.js` +6. Navigate to tokenCredentialAuthenticationProvider[./samples/javascript/clientInitialization/tokenCredentialAuthenticationProvider] in the samples directory. + +7. For running this javascript sample, run `node index.js` diff --git a/samples/javascript/clientInitialization/tokenCredentialAuthenticationProvider/index.js b/samples/javascript/clientInitialization/tokenCredentialAuthenticationProvider/index.js index b26af5817..3854df6bd 100644 --- a/samples/javascript/clientInitialization/tokenCredentialAuthenticationProvider/index.js +++ b/samples/javascript/clientInitialization/tokenCredentialAuthenticationProvider/index.js @@ -13,10 +13,6 @@ const { clientId, clientSecret, scopes, tenantId } = require("./secrets"); require("isomorphic-fetch"); const port = ""; -const tenantId = ""; -const clientId = ""; -const clientSecret = ""; -const scopes = ""; const redirectUri = `http://localhost:${port}/authresponse`; const authorityHost = "https://login.microsoftonline.com"; diff --git a/samples/javascript/clientInitialization/tokenCredentialAuthenticationProvider/secrets.js b/samples/javascript/clientInitialization/tokenCredentialAuthenticationProvider/secrets.js new file mode 100644 index 000000000..471a6d500 --- /dev/null +++ b/samples/javascript/clientInitialization/tokenCredentialAuthenticationProvider/secrets.js @@ -0,0 +1,11 @@ +const tenantId = ""; +const clientId = ""; +const clientSecret = ""; +const scopes = ""; + +module.exports = { + tenantId: tenantId, + clientId: clientId, + clientSecret: clientSecret, + scopes: scopes +} \ No newline at end of file