Check for object when extracting error #78
Conversation
We've been using this library (npm version v1.0.0) in production and had a few occurrences of: ``` TypeError: Cannot use 'in' operator to search for 'error' in undefined at Function.ResponseHandler.ParseError (ResponseHandler.js:20) at Function.ResponseHandler.init (ResponseHandler.js:14) at (/app/node_modules/@microsoft/microsoft-graph-client/lib/src/GraphRequest.js:191) ``` I've changed the check to ensure the `in` operator is only being used against an object.
| var errObj; | ||
| if (!('rawResponse' in rawErr)) { | ||
| if (rawErr.response !== undefined && rawErr.response.body !== null && 'error' in rawErr.response.body) { | ||
| if (rawErr.response !== undefined && rawErr.response.body !== null && typeof rawErr.response.body === 'object' && 'error' in rawErr.response.body) { |
There was a problem hiding this comment.
should not it be better to check with the following condition
(rawErr.response !== undefined && rawErr.response.body !== undefined && rawErr.response.body !== null && 'error' in rawErr.response.body)
rather than finding the type and verifying it?
There was a problem hiding this comment.
The error property needs to be an object anyway so it might as well be checked.
bullsseye
left a comment
bullsseye
left a comment
There was a problem hiding this comment.
The same change needs to be done in corresponding ts file and compile it before pushing
|
ResponseHandler is refactored with the FetchAPI update PR and the similar GraphError handling bug is fixed in this PR, Since this PR is no longer valid so closing.!! @rhodgkins Appreciate your time and effort for raising this pull request. |
3 participants
We've been using this library (npm version v1.0.0) in production and had a few occurrences of:
I've changed the check to ensure the
inoperator is only being used against an object.