Skip to content

PowerShell 5.1 hard dependency fix #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 4, 2020
Merged

PowerShell 5.1 hard dependency fix #197

merged 7 commits into from
May 4, 2020

Conversation

@peombwa
Copy link
Member

@peombwa peombwa commented May 4, 2020

This PR addresses issues that have been reported when running Microsoft.Graph 0.5.0 on PowerShell 5.1.

Changes made:

  • Update all ADO pipelines to use script variables instead of environment variables when generating modules.
  • Specify dependency versions in module manifest.

Will fix #189, #187, #194

@peombwa peombwa self-assigned this May 4, 2020
@peombwa peombwa requested review from darrelmiller and ddyett May 4, 2020 19:22
ddyett
ddyett approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@ddyett ddyett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@peombwa peombwa merged commit 4efc983 into dev May 4, 2020
@peombwa peombwa deleted the po/PS51HardDependencyFix branch May 4, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

1 more reviewer

@ddyett ddyett ddyett approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@peombwa peombwa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0.5.0 cmdlets referencing microsoft.graph.authentication version 0.2.0.0

3 participants

@peombwa @ddyett