Skip to content

Conversation

@timayabi2020
Copy link
Contributor

Fixes #2201

Changes proposed in this pull request

  • Added directive to pluralize the "people" noun

@timayabi2020 timayabi2020 requested a review from a team as a code owner July 28, 2023 12:49
@peombwa
Copy link
Member

peombwa commented Jul 28, 2023

This is by design. The API returns a resource type named person - https://learn.microsoft.com/en-us/graph/api/resources/person?view=graph-rest-beta.

PowerShell requires singularization of subjects/nouns in command names whenever possible - https://learn.microsoft.com/en-us/powershell/scripting/developer/cmdlet/strongly-encouraged-development-guidelines?view=powershell-7.3#use-a-specific-noun-for-a-cmdlet-name-sd01:

To enhance the user experience, the noun that you choose for a cmdlet name should be singular. For example, use the name Get-Process instead of Get-Processes. It is best to follow this rule for all cmdlet names, even when a cmdlet is likely to act upon more than one item.

*/people* APIs have always been singularized to person even in v1.x - https://learn.microsoft.com/en-us/graph/api/user-list-people?view=graph-rest-beta&tabs=powershell#request.

@timayabi2020
Copy link
Contributor Author

@peombwa thanks for the clarification

@peombwa peombwa deleted the people-pronoun-rename branch July 31, 2023 15:15
@peombwa peombwa restored the people-pronoun-rename branch August 9, 2023 18:03
@peombwa
Copy link
Member

peombwa commented Aug 9, 2023

Reopening following an internal discussion with the workload owner. There was an API review exception given to admin/people and the condition at #2202 (comment) does not apply to the API path.

@peombwa peombwa reopened this Aug 9, 2023
peombwa and others added 2 commits August 9, 2023 11:08
@peombwa peombwa merged commit 862a79a into dev Aug 9, 2023
@peombwa peombwa deleted the people-pronoun-rename branch August 9, 2023 18:31
@peombwa peombwa mentioned this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong cmdlet generated for "/admin/people/pronouns"

3 participants