Skip to content

Task/refactor client factory #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2020
Merged

Task/refactor client factory #30

merged 3 commits into from
Apr 8, 2020

Conversation

@jobala
Copy link
Contributor

@jobala jobala commented Apr 7, 2020 •
edited
Loading

Overview

Exposes GraphSession instead of HTTPClientFactory
Refactors middlewares to middleware

graph_session = GraphSession(middleware=middleware)
graph_session.get('/me')

closes #20
closes #29

@jobala jobala added the enhancement New feature or request label Apr 7, 2020
@jobala jobala changed the base branch from feat/support-multiple-scopes to dev April 8, 2020 21:05
@jobala jobala merged commit a6d06af into dev Apr 8, 2020
@MIchaelMainer MIchaelMainer deleted the task/refactor-client-factory branch April 16, 2020 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose GraphSession Is a HTTPClient appropriate?

2 participants

@jobala