New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to iOS #48

Closed
micuintus opened this Issue Dec 15, 2016 · 3 comments

Comments

Projects
None yet
2 participants

jmastr added a commit that referenced this issue Feb 15, 2017

jmastr added a commit that referenced this issue Feb 15, 2017

[ios] do not show right angle on SimpleRow
Until we have our final row design, we just do not show the indicator.

Also add source code for possible own disclosure implementation.

Ref #48

micuintus added a commit that referenced this issue Feb 16, 2017

Switch to resource based compilation
even for development builds,
because

   1. Neither the DEPLOYMENTFOLDERS directive
      nor the OTHER_FILES mechanism are documented
      qmake features.

   2. The DEPLOYMENTFOLDERS feature does not seem
      to be very reliable (you had to go for clean
      builds to make sure your application's content
      is up to date with the current state of the *.pro
      file).

   3. By doing so, we can unfiy the Sailfish and v-play
      builds.

   4. Last but not least, it enables us to way control
      way more granularly, which (QML) files end up in
      our build *and which don't*.

Closes #40

// Github issue #48

micuintus added a commit that referenced this issue Feb 16, 2017

Rubustify the JsonDownloadHelper
and switch it to a resource URI
in the fallback case.

// Github issue #4 and #48 and #40

micuintus added a commit that referenced this issue Feb 16, 2017

Fix #60: JsonDownloadHelper
and switch it to a resource URI
in the fallback case.

// Github issue #4 and #48 and #40

jmastr added a commit that referenced this issue Feb 18, 2017

[v-play] add TruncationMode.qml
Fixes:
* ReferenceError: TruncationMode is not defined

Ref #48

jmastr added a commit that referenced this issue Feb 18, 2017

[v-play] add translations to v-play builds
To update language files:

  * lupdate qml/ -ts translations/harbour-berlin-vegan.ts \
      translations/harbour-berlin-vegan-en.ts \
      translations/harbour-berlin-vegan-de.ts

  * lrelease BerlinVegan.pro

Also remove occurrences of 'id-vegan-food-nearby' manually from
translations/ folder.

Ref #48

jmastr added a commit that referenced this issue Feb 18, 2017

[v-play] add translations to v-play builds
To update language files:

  * lupdate qml/ -ts translations/harbour-berlin-vegan.ts \
      translations/harbour-berlin-vegan-en.ts \
      translations/harbour-berlin-vegan-de.ts

  * lrelease BerlinVegan.pro

Also remove occurrences of 'id-vegan-food-nearby' manually from
translations/ folder.

Ref #48

jmastr added a commit that referenced this issue Feb 18, 2017

[v-play] add translations to v-play builds
To update language files:

  * lupdate qml/ -ts translations/harbour-berlin-vegan.ts \
      translations/harbour-berlin-vegan-en.ts \
      translations/harbour-berlin-vegan-de.ts

  * lrelease BerlinVegan.pro

Also remove occurrences of 'id-vegan-food-nearby' manually from
translations/ folder.

Ref #48

micuintus added a commit that referenced this issue Feb 18, 2017

[v-play] add TruncationMode.qml
Fixes:
* ReferenceError: TruncationMode is not defined

Ref #48

micuintus added a commit that referenced this issue Feb 18, 2017

[v-play] add translations to v-play builds
To update language files:

  * lupdate qml/ -ts translations/harbour-berlin-vegan.ts \
      translations/harbour-berlin-vegan-en.ts \
      translations/harbour-berlin-vegan-de.ts

  * lrelease BerlinVegan.pro

Also remove occurrences of 'id-vegan-food-nearby' manually from
translations/ folder.

Ref #48

jmastr added a commit that referenced this issue Feb 19, 2017

jmastr added a commit that referenced this issue Feb 19, 2017

Add framework specific IconButton implementation
Both, the Sailfish SDK and the v-play SDK, offer an IconButton
implementation. However, both implementations differ, so that we need to
wrap around that.

The function 'iconBy(type)' returns the framework specific
implementation.

Ref #48

jmastr added a commit that referenced this issue Feb 19, 2017

jmastr added a commit that referenced this issue Feb 19, 2017

[v-play] add first VenueDescription implementation
The design is far away from being perfect on v-play, but it is a good
starting point for further development.

Ref #48

jmastr added a commit that referenced this issue Feb 19, 2017

[v-play] enable navigation stack in v-play builds
Therefore we connect the Sailfish's clicked(int index) signal with the
selected(int index) signal of v-play's SimpleRow and we pass through
Sailfish's PageStack to v-play's NavigationStack.

Drawback: This commit introduces some type error, which we have to
address in the future.

Ref #48

jmastr added a commit that referenced this issue Feb 19, 2017

Move iconBy() function into Theme.qml
That way we can get icons from other places in the source code as well.
In the long run, we could even get rid of the IconButton wrapper, if we
return the whole IconButton object via the iconBy() function and not
only the icon string.

Ref #48
@jmastr

This comment has been minimized.

Collaborator

jmastr commented Aug 17, 2017

photo 17 08 17 06 41 33

WE DID IT! We made it to the Apple App Store!

@jmastr jmastr closed this Aug 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment