New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Straighten out menu situation #82

Closed
micuintus opened this Issue Apr 20, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@micuintus
Owner

micuintus commented Apr 20, 2017

With the food and the shopping menu entries in place, on Sailfish the menu behaves weirdly: The shopping list gets pushed as a new page onto the stack where the food list is already. This needs to be straightened out.

@micuintus micuintus added the bug label Apr 20, 2017

@micuintus micuintus added this to the 1.0 milestone Apr 20, 2017

@micuintus micuintus self-assigned this Apr 20, 2017

micuintus added a commit that referenced this issue Apr 20, 2017

[v-play] Extract NavigationStackWithPushAttached
We extract the functionality we added to v-play
for being able to just attach a page to the navigation
stack into its own component.

// Github issue #82

micuintus added a commit that referenced this issue Apr 20, 2017

Fix #82: Straighten out menu situation
With the food and shopping menu entries in place,
on SailfishOS the menu behaves weirdly: The shopping list
gets pushed as a new page onto the stack of the food list
(without a 'PullDownMenu', which is still on the food list page).

We therefore create the entity of an 'ActionMenuItem',
which closely resembles Sailfish's PullDownMenu's 'MenuItem':
It has a 'clicked' signal, which you can connect to
for triggering some action when the menu item was clicked.

Currently, the 'ActionMenu' item uses the page component that
has been assigned to the 'initialPage' property of the
'ApplicationWindow'.

The 'NavigationMenu' abstraction on Sailfish is adapted in a
way that the menu automatically assigns itself to the first
page of Sailfish's global 'pageStack' (if it has a valid
'flickable' the 'PullDownMenu' can be attached to).

micuintus added a commit that referenced this issue May 5, 2017

micuintus added a commit that referenced this issue May 5, 2017

Don't use State based approach
as nice as it is --- but unfortunately it is
overkill for our use case.

// Github issue #82

micuintus added a commit that referenced this issue May 5, 2017

Fix bug of virtual keyboard loosing the focus
With Github issue #82 the bug of the virtual keyboard
loosing the focus was temporarily re-introduced.

// Github issue #82

micuintus added a commit that referenced this issue May 5, 2017

micuintus added a commit that referenced this issue May 5, 2017

micuintus added a commit that referenced this issue May 5, 2017

Explicify page component to use in ActionMenuItem
and don't implicitly use app.initialPage

// Github issue #82

jmastr added a commit that referenced this issue May 6, 2017

[v-play] Extract NavigationStackWithPushAttached
We extract the functionality we added to v-play
for being able to just attach a page to the navigation
stack into its own component.

// Github issue #82

jmastr added a commit that referenced this issue May 6, 2017

jmastr added a commit that referenced this issue May 6, 2017

Don't use State based approach
as nice as it is --- but unfortunately it is
overkill for our use case.

// Github issue #82

jmastr added a commit that referenced this issue May 6, 2017

Fix bug of virtual keyboard loosing the focus
With Github issue #82 the bug of the virtual keyboard
loosing the focus was temporarily re-introduced.

// Github issue #82

jmastr added a commit that referenced this issue May 6, 2017

jmastr added a commit that referenced this issue May 6, 2017

jmastr added a commit that referenced this issue May 6, 2017

Explicify page component to use in ActionMenuItem
and don't implicitly use app.initialPage

// Github issue #82

micuintus added a commit that referenced this issue Jul 13, 2017

@micuintus micuintus closed this in eb83f50 Jul 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment