Extension thumbnail have the wrong aspect ratio #39

Closed
jcfr opened this Issue Mar 27, 2013 · 3 comments

Projects

None yet

2 participants

@jcfr

Thumbnail are all resized as squared image. Is there already some code with Midas to properly resize thumbnail by keeping the original ratio ?

@zachmullen: Let me know what you think. Thanks

@zachmullen
Midas Platform member

We force the image to a set size so that every entry in the table takes up the same amount of space. If we allowed the aspect ratio to be variable, we would need to do something smart (like with imagemagick) on the server to resize the image by padding it to the appropriate aspect ratio.

@zachmullen
Midas Platform member

The problem there is that the thumbnail is just a URL, we don't necessarily have them on the server, so we would have to manage this at the browser level. The simplest way to do that is to just fix the width and height, and use the convention that extensions should have square icons of a certain size ,and if not, they are going to look weird.

@jcfr
@zachmullen zachmullen closed this Mar 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment