New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render blank pages after upgrading middleman to 3.3.2 #207

Closed
kidwm opened this Issue Apr 11, 2014 · 11 comments

Comments

Projects
None yet
5 participants
@kidwm

kidwm commented Apr 11, 2014

the repo:
https://github.com/4point/osdc.tw
all blog pages are under /news/ but now get blank content.

@Arcovion

This comment has been minimized.

Member

Arcovion commented Apr 11, 2014

This should be = wrap_layout instead of - wrap_layout:
https://github.com/4point/osdc.tw/blob/master/source/layouts/article.haml

May also require other changes, see middleman/middleman#1249

@kidwm

This comment has been minimized.

kidwm commented Apr 11, 2014

@Arcovion Thanks.
@tdreyno maybe we should give some helper examples in CHANGELOG ?

@kidwm kidwm closed this Apr 11, 2014

@Arcovion

This comment has been minimized.

Member

Arcovion commented Apr 11, 2014

It's in the middleman changelog, just not middleman-blog

@kidwm

This comment has been minimized.

kidwm commented Apr 11, 2014

@Arcovion I know that, but I didn't get the idea at the first glance.

@kidwm

This comment has been minimized.

kidwm commented Apr 11, 2014

It says 'tag helpers' in Padrino's upgrading guide, so I overlook this case.

@tdreyno

This comment has been minimized.

Member

tdreyno commented Apr 11, 2014

@kidwm Are there docs/examples using the old syntax still?

@kidwm

This comment has been minimized.

kidwm commented Apr 14, 2014

@tdreyno It seems still be.
http://middlemanapp.com/basics/templates/

<% wrap_layout :layout do %>
  <article>
    <%= yield %>
  </article>
<% end %>
@lolmaus

This comment has been minimized.

Contributor

lolmaus commented Apr 14, 2014

I think we should leave a note of the old syntax in each example. There are still people supporting projects with Middleman locked at older versions.

@tdreyno

This comment has been minimized.

Member

tdreyno commented Apr 14, 2014

@kidwm This issue only applies to Haml/Slim, not erb.

@kidwm

This comment has been minimized.

kidwm commented Apr 15, 2014

@tdreyno Oops, I forgot that. That really makes confusing.

ghedamat added a commit to ghedamat/middleman-guides that referenced this issue Dec 4, 2014

update syntax for wrap_layout
see middleman/middleman-blog#207 (comment)

got bitten by this today, I understand that the old version is ok before 3.3.2, but I think this should do no harm

let me know if this is ok :)

thanks!
@JarLowrey

This comment has been minimized.

JarLowrey commented Mar 9, 2017

This is at the top of Google Search results for "middleman blank pages". I was missing a closing } at the end of my partial's locals, which was causing a blank page (no crash or error) in Middleman 4.2.0. I upgraded to 4.2.1 and the error was shown.

Example missing brace (after page_articles):

<%= partial "partials/post_summaries.erb", locals: {
    articles: page_articles %>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment